[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <f53deeb2-bc08-4363-b8d0-ff3987409ca7@roeck-us.net>
Date: Fri, 31 May 2024 06:09:16 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: Krzysztof Kozlowski <krzk@...nel.org>, linux-hwmon@...r.kernel.org
Cc: devicetree@...r.kernel.org, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
<conor+dt@...nel.org>, linux-kernel@...r.kernel.org,
Armin Wolf <W_Armin@....de>, Thomas Weißschuh
<linux@...ssschuh.net>, René Rebe <rene@...ctcode.de>
Subject: Re: [PATCH v2 1/3] dt-bindings: hwmon: jedec,spd5118: Add bindings
On 5/31/24 01:15, Krzysztof Kozlowski wrote:
> On 31/05/2024 00:39, Guenter Roeck wrote:
>> Add device tree bindings for the SPD hub present in DDR5 modules.
>>
>> Signed-off-by: Guenter Roeck <linux@...ck-us.net>
>
> ...
>
>> +title: JEDEC JESD300-5B (SPD5118) compatible DDR5 SPD hub
>> +
>> +maintainers:
>> + - Guenter Roeck <linux@...ck-us.net>
>> +
>> +description: |
>> + JEDEC JESD300-5B.01 SPD5118 Hub and Serial Presence Detect
>> + https://www.jedec.org/standards-documents/docs/jesd300-5b01
>> +
>> +select:
>> + properties:
>> + compatible:
>> + const: jedec,spd5118
>
> Why do you need the select? This s needed for cases with multiple
> bindings using parts of compatible list. I don't see the case here so far.
>
Sorry, I am not a devicetree expert, I don't really know what I am doing,
and just copied this from some other binding. I'll try to find a better
example. Actually, I'll just add the binding to trivial devices.
Thanks,
Guenter
Powered by blists - more mailing lists