linux-kernel - Re: [PATCH v2 1/3] dt-bindings: hwmon: jedec,spd5118: Add bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <85e49c2f-e69d-4bd4-917f-0a3b12d65509@kernel.org>
Date: Fri, 31 May 2024 15:14:17 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Guenter Roeck <linux@...ck-us.net>, linux-hwmon@...r.kernel.org
Cc: devicetree@...r.kernel.org, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, linux-kernel@...r.kernel.org,
 Armin Wolf <W_Armin@....de>, Thomas Weißschuh
 <linux@...ssschuh.net>, René Rebe <rene@...ctcode.de>
Subject: Re: [PATCH v2 1/3] dt-bindings: hwmon: jedec,spd5118: Add bindings

On 31/05/2024 15:09, Guenter Roeck wrote:
> On 5/31/24 01:15, Krzysztof Kozlowski wrote:
>> On 31/05/2024 00:39, Guenter Roeck wrote:
>>> Add device tree bindings for the SPD hub present in DDR5 modules.
>>>
>>> Signed-off-by: Guenter Roeck <linux@...ck-us.net>
>>
>> ...
>>
>>> +title: JEDEC JESD300-5B (SPD5118) compatible DDR5 SPD hub
>>> +
>>> +maintainers:
>>> +  - Guenter Roeck <linux@...ck-us.net>
>>> +
>>> +description: |
>>> +  JEDEC JESD300-5B.01 SPD5118 Hub and Serial Presence Detect
>>> +  https://www.jedec.org/standards-documents/docs/jesd300-5b01
>>> +
>>> +select:
>>> +  properties:
>>> +    compatible:
>>> +      const: jedec,spd5118
>>
>> Why do you need the select? This s needed for cases with multiple
>> bindings using parts of compatible list. I don't see the case here so far.
>>
> 
> Sorry, I am not a devicetree expert, I don't really know what I am doing,
> and just copied this from some other binding. I'll try to find a better
> example. Actually, I'll just add the binding to trivial devices.

Sounds good.

Best regards,
Krzysztof