linux-kernel - Re: [PATCH v3] vmstat: Kernel stack usage histogram

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20240531173823.4ec7b4693a4e433b1da91e75@linux-foundation.org>
Date: Fri, 31 May 2024 17:38:23 -0700
From: Andrew Morton <akpm@...ux-foundation.org>
To: Pasha Tatashin <pasha.tatashin@...een.com>
Cc: Shakeel Butt <shakeel.butt@...ux.dev>, jpoimboe@...nel.org,
 kent.overstreet@...ux.dev, peterz@...radead.org, nphamcs@...il.com,
 cerasuolodomenico@...il.com, surenb@...gle.com, lizhijian@...itsu.com,
 willy@...radead.org, vbabka@...e.cz, ziy@...dia.com,
 linux-kernel@...r.kernel.org, linux-mm@...ck.org
Subject: Re: [PATCH v3] vmstat: Kernel stack usage histogram

On Thu, 30 May 2024 20:14:17 -0400 Pasha Tatashin <pasha.tatashin@...een.com> wrote:

> > Couple of questions:
> >
> > 1. In future with your on-demand kstack allocation feature, will these
> > metrics still be useful? (I think so but I want to know your take)

I do think the changelog for this patch should reference the dynamic
stack feature.  It strengthens the justification for adding this patch.

> It depends on how on-demand allocation is implemented. On hardware
> that supports faults on kernel stacks, we will have other metrics that
> show the total number of pages allocated for stacks. On hardware where
> faults are not supported, we will most likely have some optimization
> where only some threads are extended, and for those, these metrics
> will still be very useful.

Also useful changelog info for this patch.

Pasha, could you please prepare some additional text which I can paste
in?  Thanks.