linux-kernel - Re: [PATCH 3/3] thermal: cv180x: Add cv180x thermal driver support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <IA1PR20MB4953523D31D45463D5A5E5CCBBFD2@IA1PR20MB4953.namprd20.prod.outlook.com>
Date: Sat, 1 Jun 2024 08:34:23 +0800
From: Inochi Amaoto <inochiama@...look.com>
To: Haylen Chu <heylenay@...look.com>, 
	Inochi Amaoto <inochiama@...look.com>, "Rafael J. Wysocki" <rafael@...nel.org>, 
	Daniel Lezcano <daniel.lezcano@...aro.org>, Zhang Rui <rui.zhang@...el.com>, 
	Lukasz Luba <lukasz.luba@....com>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Chen Wang <unicorn_wang@...look.com>, Paul Walmsley <paul.walmsley@...ive.com>, 
	Palmer Dabbelt <palmer@...belt.com>, Albert Ou <aou@...s.berkeley.edu>, 
	Jisheng Zhang <jszhang@...nel.org>
Cc: linux-pm@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-riscv@...ts.infradead.org
Subject: Re: [PATCH 3/3] thermal: cv180x: Add cv180x thermal driver support

On Fri, May 31, 2024 at 01:37:01PM GMT, Haylen Chu wrote:
> Sorry, I forgot add cc and to in the last email. This is a resend.
> 
> On Fri, May 31, 2024 at 07:45:37AM +0800, Inochi Amaoto wrote:
> > The sensors of CV1800 support various periods, I think you should add
> > support for all of them and let user select them. The configuration
> > you use now can be left as the default.
> 
> I will make sample period configurable in next revision.
> 
> > > +{
> > > +   return ((result * 1000) * 716 / 2048 - 273000);
> > > +}
> >
> > Why these magic number, I have not see any info in the document.
> 
> Actually, there is no document of calculating real temperature from raw
> register value. The equation above is extracted from code provided by
> Sophgo.
> 
> I have figured out meaning of part of the equation and could add some
> comments to document it.
> 

I think you misunderstood. I did not only ask for the document, but also 
a formula that respects the configuration. It is pretty weird to use all
fix magic number to calculate the temp value since the sensors itself
supports various configuration, right?