linux-kernel - Re: [PATCH] riscv: dts: starfive: Update flash partition layout

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJM55Z8pntz8=aHhad4LW5cH4BLTCw5vfJPYRpYmTjtuuqiZtw@mail.gmail.com>
Date: Mon, 3 Jun 2024 15:31:35 -0500
From: Emil Renner Berthing <emil.renner.berthing@...onical.com>
To: Heinrich Schuchardt <heinrich.schuchardt@...onical.com>, 
	Emil Renner Berthing <emil.renner.berthing@...onical.com>
Cc: devicetree@...r.kernel.org, aou@...s.berkeley.edu, duwe@...e.de, 
	linux-kernel@...r.kernel.org, palmer@...belt.com, paul.walmsley@...ive.com, 
	linux-riscv@...ts.infradead.org, Matthias Brugger <matthias.bgg@...il.com>, 
	matthias.bgg@...nel.org, kernel@...il.dk, robh@...nel.org, krzk+dt@...nel.org, 
	conor+dt@...nel.org
Subject: Re: [PATCH] riscv: dts: starfive: Update flash partition layout

Heinrich Schuchardt wrote:
> On 6/3/24 18:10, Emil Renner Berthing wrote:
> > matthias.bgg@ wrote:
> >> From: Matthias Brugger <matthias.bgg@...il.com>
> >>
> >> Up to now, the describe flash partition layout has some gaps.
> >> Use the whole flash chip by getting rid of the gaps.
> >>
> >> Suggested-by: Heinrich Schuchardt <heinrich.schuchardt@...onical.com>
> >> Signed-off-by: Matthias Brugger <matthias.bgg@...il.com>
> >
> > Hi Matthias,
> >
> > Thanks for the patch.
> >
> >>
> >> ---
> >>
> >>   arch/riscv/boot/dts/starfive/jh7110-common.dtsi | 7 ++-----
> >>   1 file changed, 2 insertions(+), 5 deletions(-)
> >>
> >> diff --git a/arch/riscv/boot/dts/starfive/jh7110-common.dtsi b/arch/riscv/boot/dts/starfive/jh7110-common.dtsi
> >> index 8ff6ea64f0489..37b4c294ffcc5 100644
> >> --- a/arch/riscv/boot/dts/starfive/jh7110-common.dtsi
> >> +++ b/arch/riscv/boot/dts/starfive/jh7110-common.dtsi
> >> @@ -321,16 +321,13 @@ partitions {
> >>   			#size-cells = <1>;
> >>
> >>   			spl@0 {
> >> -				reg = <0x0 0x80000>;
> >> +				reg = <0x0 0xf0000>;
> >
> > ..this is definitely fine, but..
> >
> >>   			};
> >>   			uboot-env@...00 {
> >>   				reg = <0xf0000 0x10000>;
> >>   			};
> >>   			uboot@...000 {
> >> -				reg = <0x100000 0x400000>;
> >> -			};
> >> -			reserved-data@...000 {
> >> -				reg = <0x600000 0xa00000>;
> >> +				reg = <0x100000 0xf00000>;
> >
> > Do we know that all of the VF2 1.2A, VF2 1.3B and Milk-V Mars boards have at
> > least 15kB SPI flash chips? In other words were there a reason this previously
> > ended at 10kB?
> >
> > Also it looks like my Mars board and VF2 1.3B both report discovering a
> > "gd25lq128d" chip of 16kB, so why stop at 15kB?
>
> Hello Emil,
>
> 0xf00000 (15 MiB) is the value of the size-cell. gd25lq128d has 128 Mbit
> (=16 MiB).
>
> Cf. the examples in
> Documentation/devicetree/bindings/mtd/partitions/fixed-partitions.yaml
>
> The prior partition scheme had a partition 'reserved-data' also ending
> at 16 MiB. We don't change the expected size with the current patch.

Oh, you're right. I totally misread that, sorry. You can add my

Reviewed-by: Emil Renner Berthing <emil.renner.berthing@...onical.com>