linux-kernel - Re: [PATCH] readdir: Add missing quote in macro comment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Zl4//pUnGQJhtNDL@dread.disaster.area>
Date: Tue, 4 Jun 2024 08:13:18 +1000
From: Dave Chinner <david@...morbit.com>
To: Thorsten Blum <thorsten.blum@...lux.com>
Cc: Alexander Viro <viro@...iv.linux.org.uk>,
	Christian Brauner <brauner@...nel.org>, Jan Kara <jack@...e.cz>,
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] readdir: Add missing quote in macro comment

On Sun, Jun 02, 2024 at 02:47:30AM +0200, Thorsten Blum wrote:
> Add a missing double quote in the unsafe_copy_dirent_name() macro
> comment.
> 
> Signed-off-by: Thorsten Blum <thorsten.blum@...lux.com>
> ---
>  fs/readdir.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/readdir.c b/fs/readdir.c
> index 278bc0254732..5045e32f1cb6 100644
> --- a/fs/readdir.c
> +++ b/fs/readdir.c
> @@ -72,7 +72,7 @@ int wrap_directory_iterator(struct file *file,
>  EXPORT_SYMBOL(wrap_directory_iterator);
>  
>  /*
> - * Note the "unsafe_put_user() semantics: we goto a
> + * Note the "unsafe_put_user()" semantics: we goto a

No need for the quotes in the first place, so why not just remove
them altogether?

-Dave.
-- 
Dave Chinner
david@...morbit.com