linux-kernel - [PATCH] iio: humidity: si7020: add heater support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue,  4 Jun 2024 01:03:23 +0200
From: Antoni Pokusinski <apokusinski01@...il.com>
To: jic23@...nel.org
Cc: apokusinski01@...il.com,
	apokusinski@...pl,
	linux-iio@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: [PATCH] iio: humidity: si7020: add heater support

Hello, thanks for the review. I have a one question though:

>> @@ -134,6 +259,10 @@ static int si7020_probe(struct i2c_client *client)
>>  	indio_dev->channels = si7020_channels;
>>  	indio_dev->num_channels = ARRAY_SIZE(si7020_channels);
>>  
>> +	/* Default register values */
>> +	data->user_reg = 0x3A;

>Can you build that up from fields with names?
>I don't like a magic value where I have no idea what some of the bits are.

In the datasheet it's said that all the bits that are set by default in
the `user_reg` are "reserved" and have no meaning for now. So perhaps
mentioning this in a simple comment would be sufficient here?