linux-kernel - Re: [PATCH] KVM: x86: add missing MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <022bf315-9ec2-4cc9-b007-922d7b95d5dd@quicinc.com>
Date: Mon, 3 Jun 2024 16:21:28 -0700
From: Jeff Johnson <quic_jjohnson@...cinc.com>
To: Sean Christopherson <seanjc@...gle.com>
CC: Paolo Bonzini <pbonzini@...hat.com>, Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        Dave Hansen
	<dave.hansen@...ux.intel.com>, <x86@...nel.org>,
        "H. Peter Anvin"
	<hpa@...or.com>, <kvm@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] KVM: x86: add missing MODULE_DESCRIPTION() macros

On 6/3/2024 4:09 PM, Sean Christopherson wrote:
> On Tue, May 28, 2024, Jeff Johnson wrote:
>> Fix the following allmodconfig 'make W=1' warnings when building for x86:
>> WARNING: modpost: missing MODULE_DESCRIPTION() in arch/x86/kvm/kvm.o
>> WARNING: modpost: missing MODULE_DESCRIPTION() in arch/x86/kvm/kvm-intel.o
>> WARNING: modpost: missing MODULE_DESCRIPTION() in arch/x86/kvm/kvm-amd.o
>>
>> Signed-off-by: Jeff Johnson <quic_jjohnson@...cinc.com>
>> ---
>>  arch/x86/kvm/svm/svm.c | 1 +
>>  arch/x86/kvm/vmx/vmx.c | 1 +
>>  virt/kvm/kvm_main.c    | 1 +
>>  3 files changed, 3 insertions(+)
>>
>> diff --git a/arch/x86/kvm/svm/svm.c b/arch/x86/kvm/svm/svm.c
>> index c8dc25886c16..bdd39931720c 100644
>> --- a/arch/x86/kvm/svm/svm.c
>> +++ b/arch/x86/kvm/svm/svm.c
>> @@ -53,6 +53,7 @@
>>  #include "svm_onhyperv.h"
>>  
>>  MODULE_AUTHOR("Qumranet");
>> +MODULE_DESCRIPTION("KVM SVM (AMD-V) extensions");
> 
> How about "KVM support for SVM (AMD-V) extensions"?
> 
>>  MODULE_LICENSE("GPL");
>>  
>>  #ifdef MODULE
>> diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c
>> index 6051fad5945f..956e6062f311 100644
>> --- a/arch/x86/kvm/vmx/vmx.c
>> +++ b/arch/x86/kvm/vmx/vmx.c
>> @@ -74,6 +74,7 @@
>>  #include "posted_intr.h"
>>  
>>  MODULE_AUTHOR("Qumranet");
>> +MODULE_DESCRIPTION("KVM VMX (Intel VT-x) extensions");
> 
> And then a similar thing here.
> 
>>  MODULE_LICENSE("GPL");
>>  
>>  #ifdef MODULE
>> diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
>> index 14841acb8b95..b03d06ca29c4 100644
>> --- a/virt/kvm/kvm_main.c
>> +++ b/virt/kvm/kvm_main.c
>> @@ -74,6 +74,7 @@
>>  #define ITOA_MAX_LEN 12
>>  
>>  MODULE_AUTHOR("Qumranet");
>> +MODULE_DESCRIPTION("Kernel-based Virtual Machine driver for Linux");
> 
> Maybe "Kernel-based Virtual Machine (KVM) Hypervisor"?  I personally never think
> of KVM as a "driver", though I know it's been called that in the past.  And having
> "Hypervisor" in the name might help unfamiliar users.

Thanks for the suggestions since my first past was just gleaned from existing
code headers and Kconfig help text. Will spin a v2 after waiting for any
further comments.

/jeff