linux-kernel - Re: [PATCH v2 4/5] platform/chrome: cros_ec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zl2NYTIWtt604WXm@google.com>
Date: Mon, 3 Jun 2024 09:31:13 +0000
From: Tzung-Bi Shih <tzungbi@...nel.org>
To: Ben Walsh <ben@...nut.com>
Cc: Benson Leung <bleung@...omium.org>, Guenter Roeck <groeck@...omium.org>,
	"Dustin L. Howett" <dustin@...ett.net>,
	Kieran Levin <ktl@...me.work>,
	Thomas Weißschuh <linux@...ssschuh.net>,
	Mario Limonciello <mario.limonciello@....com>,
	chrome-platform@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 4/5] platform/chrome: cros_ec_lpc: Add a new quirk for
 AML mutex

On Mon, Jun 03, 2024 at 07:38:33AM +0100, Ben Walsh wrote:
> @@ -484,6 +492,18 @@ static int cros_ec_lpc_probe(struct platform_device *pdev)
>  			}
>  			ACPI_COMPANION_SET(dev, adev);
>  		}
> +
> +		if (quirks & CROS_EC_LPC_QUIRK_AML_MUTEX) {
> +			const char *name
> +				= driver_data->quirk_aml_mutex_name;
> +			ret = cros_ec_lpc_mec_acpi_mutex(adev, name);

* Assuming the `adev = ACPI_COMPANION(dev);` didn't move in previous patch,
  `adev` here could be uninitialized.

* Also, it shouldn't rely on CROS_EC_LPC_QUIRK_ACPI_ID to set the `adev`.

To keep it simple, I would suggest to use ACPI_COMPANION() instead.