linux-kernel - Re: [PATCH v2 3/5] platform/chrome: cros_ec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c8d765bc-4e45-40b3-a33d-b4cc1bbd67bd@amd.com>
Date: Mon, 3 Jun 2024 11:00:22 -0500
From: Mario Limonciello <mario.limonciello@....com>
To: Tzung-Bi Shih <tzungbi@...nel.org>, Ben Walsh <ben@...nut.com>
Cc: Benson Leung <bleung@...omium.org>, Guenter Roeck <groeck@...omium.org>,
 "Dustin L. Howett" <dustin@...ett.net>, Kieran Levin <ktl@...me.work>,
 Thomas Weißschuh <linux@...ssschuh.net>,
 chrome-platform@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 3/5] platform/chrome: cros_ec_lpc: Add a new quirk for
 ACPI id

On 6/3/2024 04:30, Tzung-Bi Shih wrote:
> On Mon, Jun 03, 2024 at 07:38:32AM +0100, Ben Walsh wrote:
>> @@ -436,6 +463,8 @@ static int cros_ec_lpc_probe(struct platform_device *pdev)
>>   
>>   	ec_lpc->mmio_memory_base = EC_LPC_ADDR_MEMMAP;
>>   
>> +	adev = ACPI_COMPANION(dev);
>> +
> 
> The change is irrelevant to the patch.

It looks relevant to me.  The companion needs to get set before the 
quirk overwrites it.

> 
>> @@ -538,7 +577,6 @@ static int cros_ec_lpc_probe(struct platform_device *pdev)
>>   	 * Connect a notify handler to process MKBP messages if we have a
>>   	 * companion ACPI device.
>>   	 */
>> -	adev = ACPI_COMPANION(dev);
>>   	if (adev) {
>>   		status = acpi_install_notify_handler(adev->handle,
>>   						     ACPI_ALL_NOTIFY,
> 
> See above comment.