linux-kernel - Re: [PATCH 1/3] net: ti: icssg-prueth: Enable PTP timestamping support for SR1.0 devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b154663e-db1b-4f9b-8f8e-8da832b0edfd@siemens.com>
Date: Mon, 3 Jun 2024 10:55:19 +0100
From: Diogo Ivo <diogo.ivo@...mens.com>
To: Jacob Keller <jacob.e.keller@...el.com>,
 MD Danish Anwar <danishanwar@...com>, Roger Quadros <rogerq@...nel.org>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Richard Cochran <richardcochran@...il.com>, Nishanth Menon <nm@...com>,
 Vignesh Raghavendra <vigneshr@...com>, Tero Kristo <kristo@...nel.org>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Jan Kiszka <jan.kiszka@...mens.com>
Cc: linux-arm-kernel@...ts.infradead.org, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
 diogo.ivo@...mens.com
Subject: Re: [PATCH 1/3] net: ti: icssg-prueth: Enable PTP timestamping
 support for SR1.0 devices

Hi Jacob,

On 5/30/24 7:43 PM, Jacob Keller wrote:
> 
> 
> On 5/29/2024 9:05 AM, Diogo Ivo wrote:
>> +	ret = icss_iep_init(prueth->iep0, NULL, NULL, 0);
>> +	if (ret) {
>> +		dev_err_probe(dev, ret, "failed to init iep0\n");
>> +		goto put_iep;
>> +	}
>> +
>> +	ret = icss_iep_init(prueth->iep1, NULL, NULL, 0);
>> +	if (ret) {
>> +		dev_err_probe(dev, ret, "failed to init iep1\n");
>> +		goto exit_iep0;
>> +	}
>> +
> 
> Once initialized, the icss_iep driver logic must implement the actual
> PTP clock interfaces?

Yes exactly, the IEP driver then implements the PHC operations.

> Neat.
> 
> Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>

Thank you for the review!

Best regards,
Diogo