linux-kernel - Re: [EXTERNAL] [PATCH 2/3] net: ti: icss-iep: Enable compare events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3b8ef6f2-4a06-4028-8a6f-f63b30ff8930@siemens.com>
Date: Mon, 3 Jun 2024 11:02:20 +0100
From: Diogo Ivo <diogo.ivo@...mens.com>
To: Sunil Kovvuri Goutham <sgoutham@...vell.com>,
 MD Danish Anwar <danishanwar@...com>, Roger Quadros <rogerq@...nel.org>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Richard Cochran <richardcochran@...il.com>, Nishanth Menon <nm@...com>,
 Vignesh Raghavendra <vigneshr@...com>, Tero Kristo <kristo@...nel.org>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Jan Kiszka <jan.kiszka@...mens.com>
Cc: "linux-arm-kernel@...ts.infradead.org"
 <linux-arm-kernel@...ts.infradead.org>,
 "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
 diogo.ivo@...mens.com
Subject: Re: [EXTERNAL] [PATCH 2/3] net: ti: icss-iep: Enable compare events

Hi Sunil,

On 5/31/24 6:12 AM, Sunil Kovvuri Goutham wrote:
>> From: Diogo Ivo <diogo.ivo@...mens.com>
>> Sent: Wednesday, May 29, 2024 9:35 PM
>>
>> +	iep->cap_cmp_irq = platform_get_irq_byname_optional(pdev,
>> "iep_cap_cmp");
>> +	if (iep->cap_cmp_irq < 0) {
>> +		if (iep->cap_cmp_irq == -EPROBE_DEFER)
>> +			return iep->cap_cmp_irq;
> 
> This info is coming from DT, is PROBE_DIFFER error return value possible ?

 From my understanding -EPROBE_DEFER is a possible error code.
platform_get_irq_byname_optional() will eventually call of_irq_get()
where we get -EPROBE_DEFER if the IRQ domain still hasn't been
initialized.

>> +		iep->cap_cmp_irq = 0;
>> +	} else {
>> +		ret = devm_request_irq(dev, iep->cap_cmp_irq,
>> +				       icss_iep_cap_cmp_irq,
>> IRQF_TRIGGER_HIGH,
>> +				       "iep_cap_cmp", iep);
>> +		if (ret)
>> +			return dev_err_probe(iep->dev, ret,
>> +					     "Request irq failed for cap_cmp\n");
> 
> Can't this driver live without this feature ?

Yes it can! I'll rework this logic so that we do not fail to probe
here and simply continue without PPS event support.

Thank you for the review!

Best regards,
Diogo