linux-kernel - Re: [PATCH] cpufreq: enable 1200Mhz clock speed for armada-37xx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f2284d6b-2e75-4896-9e10-caf2f72854a0@lunn.ch>
Date: Mon, 3 Jun 2024 14:46:30 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Benjamin Schneider <bschnei@...il.com>
Cc: Gregory Clement <gregory.clement@...tlin.com>,
	Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	Benjamin Schneider <ben@...s.haus>
Subject: Re: [PATCH] cpufreq: enable 1200Mhz clock speed for armada-37xx

On Sun, Jun 02, 2024 at 06:26:38PM -0700, Benjamin Schneider wrote:
> This frequency was disabled because of unresolved stability problems.
> However, based on several months of testing, the source of the
> stability problems seems to be the bootloader, not the kernel.
> Marvell has recently merged changes to their bootloader source that
> addresses the stability issues when frequency scaling is enabled at
> all frequencies including 1.2Ghz.

The problem is, most systems don't have the new bootloader. And so if
you enable 1.2GHz, they are going to be unstable.

Rather than making this unconditional, i think it needs to be
conditional on knowing the bootloader has been upgraded. Could you add
code which looks in the DDRPHY and see if 0xC0001004 has the correct
value. Only then enable the additional clock speed.

	Andrew