[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1717420513010.hwqncbrma24lbz30knw4rdzi@android.mail.163.com>
Date: Mon, 03 Jun 2024 21:15:13 +0800
From: "gxxa03070307@...il.com" <gxxa03070307@...il.com>
To: pmladek <pmladek@...e.com>
Cc: "john.ogness" <john.ogness@...utronix.de>, rostedt <rostedt@...dmis.org>,
senozhatsky <senozhatsky@...omium.org>, linux-kernel
<linux-kernel@...r.kernel.org>, fengqi <fengqi@...omi.com>,
高翔 <gaoxiang19870307@....com>
Subject: Re: [PATCH] printk: Increase PRINTK_PREFIX_MAX and the buf size in
print_caller.
https://android.googlesource.com/kernel/common/+/refs/heads/android15-6.6/kernel/printk/printk.c
We are based on google source code development, this is the link to google source code printk.c, which adds trace_android_vh_printk_caller, if we want to change the buf size must first merge into linux main line.
gxxa03070307@...il.com
邮箱:gxxa03070307@...il.com
---- Replied Message ----
From Petr Mladek<pmladek@...e.com> Date 06/03/2024 20:42 To gxxa03070307@...il.com Cc john.ogness<john.ogness@...utronix.de>、rostedt<rostedt@...dmis.org>、senozhatsky<senozhatsky@...omium.org>、linux-kernel<linux-kernel@...r.kernel.org>、fengqi<fengqi@...omi.com>、高翔<gaoxiang19870307@....com> Subject Re: [PATCH] printk: Increase PRINTK_PREFIX_MAX and the buf size in print_caller.
On Mon 2024-06-03 16:47:01, gxxa03070307@...il.com wrote:
> I need to populate the temporary variable "caller" in "print_caller" func with the additional information. And it's no use defining a buf in out-of-tree patch.
> In out-of-tree patch, I can only add hooks (special cases), I can't change anything else, because it needs to be consistent with mainline linux.
> caller buf in mainline linux is it better to make the buf bigger and leave some space?
I do not understand. Why the buffer size has to be consistent with
mainline linux?
Really, it does not make much sense to upstream just this part
of your out-of-tree patch?
Best Regards,
Petr
Content of type "text/html" skipped
Download attachment "Screenshot_2024-06-03-21-02-27-142_com.android.browser-edit.jpg" of type "image/jpeg" (114111 bytes)
Powered by blists - more mailing lists