linux-kernel - Re: [PATCH] fix: Prevent memory leak by checking for NULL buffer before calling css

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d9fbc964-c5fd-4b55-8f9b-db6971c3188c@web.de>
Date: Mon, 3 Jun 2024 15:15:41 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Geunsik Lim <geunsik.lim@...sung.com>, linux-mm@...ck.org
Cc: Geunsik Lim <leemgs@...il.com>, LKML <linux-kernel@...r.kernel.org>,
 Andrew Morton <akpm@...ux-foundation.org>,
 Axel Rasmussen <axelrasmussen@...gle.com>, "H. Peter Anvin" <hpa@...or.com>,
 Hugh Dickins <hughd@...gle.com>, Ingo Molnar <mingo@...e.hu>,
 Peter Zijlstra <a.p.zijlstra@...llo.nl>, Steven Rostedt
 <rostedt@...dmis.org>, Thomas Gleixner <tglx@...utronix.de>,
 Vlastimil Babka <vbabka@...e.cz>
Subject: Re: [PATCH] fix: Prevent memory leak by checking for NULL buffer
 before calling css_put()

…
> Previously, the code would directly call `css_put()` without checking
> the value of
> `buf`, which could lead to a memory leak if the buffer allocation failed.
> This commit introduces a conditional check to ensure that `css_put()`
> is only called
> if `buf` is not NULL.
…

How did you come to the conclusion that such a source code adjustment
would trigger a desirable effect?
https://elixir.bootlin.com/linux/v6.10-rc2/source/mm/mmap_lock.c#L188

By the way:
Would you like to reconsider word wrapping for such change descriptions
any more?

Regards,
Markus