linux-kernel - Re: [PATCH] riscv: dts: starfive: Update flash partition layout

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8e50216c-2a3a-4946-ad90-9d66c6aae20c@canonical.com>
Date: Mon, 3 Jun 2024 17:27:19 +0200
From: Heinrich Schuchardt <heinrich.schuchardt@...onical.com>
To: matthias.bgg@...nel.org
Cc: devicetree@...r.kernel.org, aou@...s.berkeley.edu, duwe@...e.de,
 linux-kernel@...r.kernel.org, palmer@...belt.com, paul.walmsley@...ive.com,
 linux-riscv@...ts.infradead.org, Matthias Brugger <matthias.bgg@...il.com>,
 kernel@...il.dk, robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org,
 Hal Feng <hal.feng@...rfivetech.com>,
 Minda Chen <minda.chen@...rfivetech.com>
Subject: Re: [PATCH] riscv: dts: starfive: Update flash partition layout

On 03.06.24 17:07, matthias.bgg@...nel.org wrote:
> From: Matthias Brugger <matthias.bgg@...il.com>
> 
> Up to now, the describe flash partition layout has some gaps.
> Use the whole flash chip by getting rid of the gaps.
> 
> Suggested-by: Heinrich Schuchardt <heinrich.schuchardt@...onical.com>
> Signed-off-by: Matthias Brugger <matthias.bgg@...il.com>

For flashing larger firmware like EDK II it is helpful to maximize the 
partition sizes. Thanks for sending the patch.

Commit 8384087a ("riscv: dts: starfive: Add QSPI controller node for 
StarFive JH7110 SoC") 
https://lore.kernel.org/linux-riscv/20230804020254.291239-4-william.qiu@starfivetech.com/ 
introduced the current layout.

CCing Starfive's U-Boot reviewers.

Reviewed-by: Heinrich Schuchardt <heinrich.schuchardt@...onical.com>

> 
> ---
> 
>   arch/riscv/boot/dts/starfive/jh7110-common.dtsi | 7 ++-----
>   1 file changed, 2 insertions(+), 5 deletions(-)
> 
> diff --git a/arch/riscv/boot/dts/starfive/jh7110-common.dtsi b/arch/riscv/boot/dts/starfive/jh7110-common.dtsi
> index 8ff6ea64f0489..37b4c294ffcc5 100644
> --- a/arch/riscv/boot/dts/starfive/jh7110-common.dtsi
> +++ b/arch/riscv/boot/dts/starfive/jh7110-common.dtsi
> @@ -321,16 +321,13 @@ partitions {
>   			#size-cells = <1>;
>   
>   			spl@0 {
> -				reg = <0x0 0x80000>;
> +				reg = <0x0 0xf0000>;
>   			};
>   			uboot-env@...00 {
>   				reg = <0xf0000 0x10000>;
>   			};
>   			uboot@...000 {
> -				reg = <0x100000 0x400000>;
> -			};
> -			reserved-data@...000 {
> -				reg = <0x600000 0xa00000>;
> +				reg = <0x100000 0xf00000>;
>   			};
>   		};
>   	};