linux-kernel - Re: [PATCH] riscv: dts: starfive: Update flash partition layout

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJM55Z82+_RL1Z+DCW+_xgE7ZMmiWdPekCt6qtREPXg1jB+68g@mail.gmail.com>
Date: Mon, 3 Jun 2024 16:10:52 +0000
From: Emil Renner Berthing <emil.renner.berthing@...onical.com>
To: matthias.bgg@...nel.org, kernel@...il.dk, robh@...nel.org, 
	krzk+dt@...nel.org, conor+dt@...nel.org
Cc: devicetree@...r.kernel.org, aou@...s.berkeley.edu, duwe@...e.de, 
	linux-kernel@...r.kernel.org, palmer@...belt.com, 
	heinrich.schuchardt@...onical.com, paul.walmsley@...ive.com, 
	linux-riscv@...ts.infradead.org, Matthias Brugger <matthias.bgg@...il.com>
Subject: Re: [PATCH] riscv: dts: starfive: Update flash partition layout

matthias.bgg@ wrote:
> From: Matthias Brugger <matthias.bgg@...il.com>
>
> Up to now, the describe flash partition layout has some gaps.
> Use the whole flash chip by getting rid of the gaps.
>
> Suggested-by: Heinrich Schuchardt <heinrich.schuchardt@...onical.com>
> Signed-off-by: Matthias Brugger <matthias.bgg@...il.com>

Hi Matthias,

Thanks for the patch.

>
> ---
>
>  arch/riscv/boot/dts/starfive/jh7110-common.dtsi | 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/arch/riscv/boot/dts/starfive/jh7110-common.dtsi b/arch/riscv/boot/dts/starfive/jh7110-common.dtsi
> index 8ff6ea64f0489..37b4c294ffcc5 100644
> --- a/arch/riscv/boot/dts/starfive/jh7110-common.dtsi
> +++ b/arch/riscv/boot/dts/starfive/jh7110-common.dtsi
> @@ -321,16 +321,13 @@ partitions {
>  			#size-cells = <1>;
>
>  			spl@0 {
> -				reg = <0x0 0x80000>;
> +				reg = <0x0 0xf0000>;

..this is definitely fine, but..

>  			};
>  			uboot-env@...00 {
>  				reg = <0xf0000 0x10000>;
>  			};
>  			uboot@...000 {
> -				reg = <0x100000 0x400000>;
> -			};
> -			reserved-data@...000 {
> -				reg = <0x600000 0xa00000>;
> +				reg = <0x100000 0xf00000>;

Do we know that all of the VF2 1.2A, VF2 1.3B and Milk-V Mars boards have at
least 15kB SPI flash chips? In other words were there a reason this previously
ended at 10kB?

Also it looks like my Mars board and VF2 1.3B both report discovering a
"gd25lq128d" chip of 16kB, so why stop at 15kB?

/Emil