linux-kernel - Re: [PATCH] null_blk: fix validation of block size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <66a8c62b-9202-4de8-8789-1f724a5ce5f8@acm.org>
Date: Mon, 3 Jun 2024 10:03:14 -0700
From: Bart Van Assche <bvanassche@....org>
To: Damien Le Moal <dlemoal@...nel.org>, John Garry
 <john.g.garry@...cle.com>, Andreas Hindborg <nmi@...aspace.dk>,
 Jens Axboe <axboe@...nel.dk>
Cc: Andreas Hindborg <a.hindborg@...sung.com>, Keith Busch
 <kbusch@...nel.org>, linux-block@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] null_blk: fix validation of block size

On 6/2/24 16:59, Damien Le Moal wrote:
> On 6/2/24 19:57, John Garry wrote:
>> On 01/06/2024 21:23, Andreas Hindborg wrote:
>>> From: Andreas Hindborg <a.hindborg@...sung.com>
>>>
>>> Block size should be between 512
>>> and 4096
>>
>> Or PAGE_SIZE?
> 
> PAGE_SIZE can be larger than 4096. But most drives are 512 or 4096 LBA-sized.

null_blk is not a physical device. Hence, why not to use 
blk_validate_block_size() here?

Thanks,

Bart.