lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <28fc5c30-ece5-4436-b066-3142147a4547@acm.org>
Date: Mon, 3 Jun 2024 10:02:03 -0700
From: Bart Van Assche <bvanassche@....org>
To: Andreas Hindborg <nmi@...aspace.dk>, Jens Axboe <axboe@...nel.dk>
Cc: Andreas Hindborg <a.hindborg@...sung.com>, Keith Busch
 <kbusch@...nel.org>, linux-block@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] null_blk: fix validation of block size

On 6/1/24 13:23, Andreas Hindborg wrote:
> +	    ((dev->blocksize & (dev->blocksize - 1)) != 0)) {

Please use is_power_of_2() instead of open-coding it.

Bart.

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ