linux-kernel - Re: [PATCH] platform: Make platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2024060432-relieving-yonder-85ae@gregkh>
Date: Tue, 4 Jun 2024 18:13:54 +0200
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
Cc: "Rafael J. Wysocki" <rafael@...nel.org>,
	Mark Brown <broonie@...nel.org>, Takashi Iwai <tiwai@...e.de>,
	Uwe Kleine-König <uwe@...ine-koenig.org>,
	David Gow <davidgow@...gle.com>, linux-kernel@...r.kernel.org,
	kernel@...gutronix.de, Philipp Zabel <p.zabel@...gutronix.de>,
	Nishanth Menon <nm@...com>, Jeremy Kerr <jk@...abs.org>,
	Rodolfo Giometti <giometti@...eenne.com>,
	Thierry Reding <treding@...dia.com>,
	Matt Coster <matt.coster@...tec.com>,
	Thomas Zimmermann <tzimmermann@...e.de>,
	Dave Jiang <dave.jiang@...el.com>,
	Dan Williams <dan.j.williams@...el.com>,
	Vishal Verma <vishal.l.verma@...el.com>,
	Bjorn Andersson <andersson@...nel.org>
Subject: Re: [PATCH] platform: Make platform_driver::remove() return void

On Mon, May 27, 2024 at 10:34:15AM +0200, Uwe Kleine-König wrote:
> struct platform_driver::remove returning an integer made driver authors
> expect that returning an error code was proper error handling. However
> the driver core ignores the error and continues to remove the device
> because there is nothing the core could do anyhow and reentering the
> remove callback again is only calling for trouble.
> 
> To prevent such wrong assumptions, change the return type of the remove
> callback to void. This was prepared by introducing an alternative remove
> callback returning void and converting all drivers to that. So .remove()
> can be changed without further changes in drivers.
> 
> This corresponds to step b) of the plan outlined in commit
> 5c5a7680e67b ("platform: Provide a remove callback that returns no value").
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> ---
> Hello Greg,
> 
> there are only very little platform drivers left in v6.10-rc1 that need
> to be changed to .remove_new() before this patch can be applied. They
> were all sent out to the respective maintainers, most of them suggested
> to apply the patches together with this one.
> 
> You can fetch this patch together with all necessary commits from:
> 
> 	https://git.kernel.org/pub/scm/linux/kernel/git/ukleinek/linux.git platform-remove-void
> 
> If you have no concerns, I can also provide you a signed tag for
> pulling. I think that's easier than indiviually applying them, but I can
> also send out the complete series if you prefer.

A signed tag is good, I can just pull from that, thanks!

greg k-h