linux-kernel - Re: [PATCH] iommu/arm-smmu-v3: Avoid uninitialized asid in case of error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <30b1fd0f-d43d-497d-b372-5218f7b4153b@moroto.mountain>
Date: Tue, 4 Jun 2024 22:09:05 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Mostafa Saleh <smostafa@...gle.com>
Cc: will@...nel.org, robin.murphy@....com,
	linux-arm-kernel@...ts.infradead.org, iommu@...ts.linux.dev,
	linux-kernel@...r.kernel.org, joro@...tes.org, jgg@...dia.com,
	nicolinc@...dia.com, mshavit@...gle.com
Subject: Re: [PATCH] iommu/arm-smmu-v3: Avoid uninitialized asid in case of
 error

On Tue, Jun 04, 2024 at 06:52:18PM +0000, Mostafa Saleh wrote:
> A simple fix would be just to initialize the local variable to zero,
> this path will only be reached on the first attach to a domain where
> the CD is already initialized to zero.
> This avoids having to bloat the function with an error path.

Yep.  Since everyone automatically zeroes stack variables these days,
this patch doesn't have any impact on runtime at all.  It's free.  It
just silences warning.

regards,
dan carpenter