linux-kernel - Re: [PATCH] iommu/arm-smmu-v3: Avoid uninitialized asid in case of error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <171759168166.1126369.9985606897560767685.b4-ty@kernel.org>
Date: Wed,  5 Jun 2024 16:45:46 +0100
From: Will Deacon <will@...nel.org>
To: robin.murphy@....com,
	linux-arm-kernel@...ts.infradead.org,
	iommu@...ts.linux.dev,
	Mostafa Saleh <smostafa@...gle.com>
Cc: catalin.marinas@....com,
	kernel-team@...roid.com,
	Will Deacon <will@...nel.org>,
	linux-kernel@...r.kernel.org,
	joro@...tes.org,
	nicolinc@...dia.com,
	mshavit@...gle.com,
	Dan Carpenter <dan.carpenter@...aro.org>,
	Jason Gunthorpe <jgg@...pe.ca>
Subject: Re: [PATCH] iommu/arm-smmu-v3: Avoid uninitialized asid in case of error

On Tue, 04 Jun 2024 18:52:18 +0000, Mostafa Saleh wrote:
> Static checker is complaining about the ASID possibly set uninitialized.
> This only happens in case of error and this value would be ignored anyway.
> 
> A simple fix would be just to initialize the local variable to zero,
> this path will only be reached on the first attach to a domain where
> the CD is already initialized to zero.
> This avoids having to bloat the function with an error path.
> 
> [...]

Applied to will (for-joerg/arm-smmu/updates), thanks!

[1/1] iommu/arm-smmu-v3: Avoid uninitialized asid in case of error
      https://git.kernel.org/will/c/d3867e714831

Cheers,
-- 
Will

https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev