linux-kernel - Re: [PATCH v4 1/7] arm64: dts: ti: am62p: Rename am62p-{}.dtsi to am62p-j722s-common-{}.dtsi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b1691eef-d385-4f86-8ec0-9059d699c221@ti.com>
Date: Tue, 4 Jun 2024 10:48:11 +0530
From: Siddharth Vadapalli <s-vadapalli@...com>
To: Andrew Davis <afd@...com>
CC: Siddharth Vadapalli <s-vadapalli@...com>, <nm@...com>, <vigneshr@...com>,
        <kristo@...nel.org>, <robh@...nel.org>, <krzk+dt@...nel.org>,
        <conor+dt@...nel.org>, <rogerq@...nel.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>, <u-kumar1@...com>,
        <danishanwar@...com>, <srk@...com>
Subject: Re: [PATCH v4 1/7] arm64: dts: ti: am62p: Rename am62p-{}.dtsi to
 am62p-j722s-common-{}.dtsi

On Mon, Jun 03, 2024 at 09:09:39AM -0500, Andrew Davis wrote:
> On 6/1/24 7:15 AM, Siddharth Vadapalli wrote:
> > The AM62P and J722S SoCs share most of the peripherals. With the aim of
> > reusing the existing k3-am62p-{mcu,main,wakeup}.dtsi files for J722S SoC,
> > rename them to indicate that they are shared with J722S SoC.
> > 
> > The peripherals that are not shared will be moved in the upcoming patches
> > to the respective k3-{soc}-{mcu,main,wakeup}.dtsi files without "common" in
> > the filename, emphasizing that they are not shared.
> > 
> > Signed-off-by: Siddharth Vadapalli <s-vadapalli@...com>
> > ---
> > No changelog since this patch is introduced in this version of the
> > series.
> > 

[...]

> > diff --git a/arch/arm64/boot/dts/ti/k3-am62p-mcu.dtsi b/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-mcu.dtsi
> > similarity index 98%
> > rename from arch/arm64/boot/dts/ti/k3-am62p-mcu.dtsi
> > rename to arch/arm64/boot/dts/ti/k3-am62p-j722s-common-mcu.dtsi
> > index b973b550eb9d..a5dbaf3ff41b 100644
> > --- a/arch/arm64/boot/dts/ti/k3-am62p-mcu.dtsi
> > +++ b/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-mcu.dtsi
> > @@ -1,6 +1,6 @@
> >   // SPDX-License-Identifier: GPL-2.0-only OR MIT
> >   /*
> > - * Device Tree file for the AM62P MCU domain peripherals
> > + * Device Tree file for the mcu domain peripherals shared by AM62P and J722S
> 
> s/mcu/MCU
> 
> Same for the other domains (WAKEUP, MAIN, MCU), makes it more clear these are names,
> and not just adjectives for the domains.

I had changed the "MCU" to "mcu" to match the convention in other files.
Based on your feedback, I seem to have switched to the wrong convention.
I will fix this in the v5 series.

> 
> >    * Copyright (C) 2023-2024 Texas Instruments Incorporated - https://www.ti.com/
> >    */
> > diff --git a/arch/arm64/boot/dts/ti/k3-am62p-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-wakeup.dtsi
> > similarity index 97%
> > rename from arch/arm64/boot/dts/ti/k3-am62p-wakeup.dtsi
> > rename to arch/arm64/boot/dts/ti/k3-am62p-j722s-common-wakeup.dtsi
> > index c71d9624ea27..ca493f4e1acd 100644
> > --- a/arch/arm64/boot/dts/ti/k3-am62p-wakeup.dtsi
> > +++ b/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-wakeup.dtsi
> > @@ -1,6 +1,6 @@
> >   // SPDX-License-Identifier: GPL-2.0-only OR MIT
> >   /*
> > - * Device Tree file for the AM62P wakeup domain peripherals
> > + * Device Tree file for the wakeup domain peripherals shared by AM62P and J722S
> 
> While we are here, might be good to add a newline here between the description
> and the copyright line to match the other SoCs DT files.
> 
> Otherwise,
> 
> Acked-by: Andrew Davis <afd@...com>

Sure, I will add the missing newline and collect your "Acked-by" tag for
this patch in the v5 series. Thank you for reviewing this patch.

[...]

Regards,
Siddharth.