linux-kernel - Re: [PATCH] selftests: drivers/s390x: Use SKIP() during FIXTURE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <211b39ae-af0c-4db9-8931-a1446f34c832@linux.ibm.com>
Date: Tue, 4 Jun 2024 09:24:47 +0200
From: Janosch Frank <frankja@...ux.ibm.com>
To: Kees Cook <keescook@...omium.org>,
        Christian Borntraeger <borntraeger@...ux.ibm.com>
Cc: Claudio Imbrenda <imbrenda@...ux.ibm.com>,
        David Hildenbrand <david@...hat.com>, Shuah Khan <shuah@...nel.org>,
        Masahiro Yamada <masahiroy@...nel.org>, kvm@...r.kernel.org,
        linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-hardening@...r.kernel.org, Steffen Eiden <seiden@...ux.ibm.com>
Subject: Re: [PATCH] selftests: drivers/s390x: Use SKIP() during FIXTURE_SETUP

On 5/18/24 02:18, Kees Cook wrote:
> Instead of mixing selftest harness and ksft helpers, perform SKIP
> testing from the FIXTURE_SETUPs. This also means TEST_HARNESS_MAIN does
> not need to be open-coded.
> 
> Signed-off-by: Kees Cook <keescook@...omium.org>
> ---

Adding the author in CC.


This changes the skip behavior from one single skip to a skip per test.
Not an issue, but a change.

But also we're generating invalid TAP AFAIK which we also have been 
before but we can fix that in this patch.

 From what I understand this line should have a "#" prefix to show that 
it's a comment:
Enable CONFIG_S390_UV_UAPI and check the access rights on /dev/uv.