linux-kernel - Re: [PATCH v1 2/6] cpufreq: intel_pstate: Do not update global.turbo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aa643910265b9d92a397d5148b31d37b2c421b8b.camel@xry111.site>
Date: Tue, 04 Jun 2024 17:30:16 +0800
From: Xi Ruoyao <xry111@...111.site>
To: srinivas pandruvada <srinivas.pandruvada@...ux.intel.com>, "Rafael J.
 Wysocki" <rafael@...nel.org>
Cc: "Rafael J. Wysocki" <rjw@...ysocki.net>, Linux PM
 <linux-pm@...r.kernel.org>,  LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v1 2/6] cpufreq: intel_pstate: Do not update
 global.turbo_disabled after initialization

On Mon, 2024-06-03 at 21:31 -0700, srinivas pandruvada wrote:

> > > Second, a delayed work can be added to check the MSR long enough
> > > after
> > > initialization and update global.turbo_disabled if it is 1. 
> > > However,
> > > that would require some code surgery.
> >
> Something like the attached which does same way as user space no_turbo
> update.

>  static int intel_pstate_register_driver(struct cpufreq_driver *driver)
>  {
>  	int ret;
> @@ -3114,6 +3137,9 @@ static int intel_pstate_register_driver(struct cpufreq_driver *driver)
>  	global.turbo_disabled = turbo_is_disabled();
>  	global.no_turbo = global.turbo_disabled;
>  
> +	if (global.turbo_disabled)
> +		schedule_delayed_work(&turbo_work, HZ);
> +

I have to change it to 20 * HZ to make it work for me.  15 * HZ does not
work.

-- 
Xi Ruoyao <xry111@...111.site>
School of Aerospace Science and Technology, Xidian University