[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <63e98f2151ef64de92cf7e3da796937755ea5552.camel@linux.intel.com>
Date: Tue, 04 Jun 2024 03:29:45 -0700
From: srinivas pandruvada <srinivas.pandruvada@...ux.intel.com>
To: Xi Ruoyao <xry111@...111.site>, "Rafael J. Wysocki" <rafael@...nel.org>
Cc: "Rafael J. Wysocki" <rjw@...ysocki.net>, Linux PM
<linux-pm@...r.kernel.org>, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v1 2/6] cpufreq: intel_pstate: Do not update
global.turbo_disabled after initialization
On Tue, 2024-06-04 at 17:30 +0800, Xi Ruoyao wrote:
> On Mon, 2024-06-03 at 21:31 -0700, srinivas pandruvada wrote:
>
> > > > Second, a delayed work can be added to check the MSR long
> > > > enough
> > > > after
> > > > initialization and update global.turbo_disabled if it is 1.
> > > > However,
> > > > that would require some code surgery.
> > >
> > Something like the attached which does same way as user space
> > no_turbo
> > update.
>
> > static int intel_pstate_register_driver(struct cpufreq_driver
> > *driver)
> > {
> > int ret;
> > @@ -3114,6 +3137,9 @@ static int
> > intel_pstate_register_driver(struct cpufreq_driver *driver)
> > global.turbo_disabled = turbo_is_disabled();
> > global.no_turbo = global.turbo_disabled;
> >
> > + if (global.turbo_disabled)
> > + schedule_delayed_work(&turbo_work, HZ);
> > +
>
> I have to change it to 20 * HZ to make it work for me. 15 * HZ does
> not
> work.
Is there any consistency or it is changing every time?
Thanks,
Srinivas
>
Powered by blists - more mailing lists