linux-kernel - Re: [RFC PATCH 2/2] net: include: mii: Refactor: Use BIT() for ADVERTISE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240605141342.262wgddrf4xjbbeu@skbuf>
Date: Wed, 5 Jun 2024 17:13:42 +0300
From: Vladimir Oltean <olteanv@...il.com>
To: Csókás, Bence <csokas.bence@...lan.hu>
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	trivial@...nel.org, Andrew Lunn <andrew@...n.ch>,
	Heiner Kallweit <hkallweit1@...il.com>,
	Russell King <linux@...linux.org.uk>
Subject: Re: [RFC PATCH 2/2] net: include: mii: Refactor: Use BIT() for
 ADVERTISE_* bits

On Wed, Jun 05, 2024 at 02:16:49PM +0200, Csókás, Bence wrote:
> Replace hex values with BIT() and GENMASK() for readability
> 
> Cc: trivial@...nel.org
> 
> Signed-off-by: "Csókás, Bence" <csokas.bence@...lan.hu>
> ---

You can't use BIT() and GENMASK() in headers exported to user space.

I mean you can, but the BIT() and GENMASK() macros themselves aren't
exported to user space, and you would break any application which used
values dependent on them.