linux-kernel - Re: [RFC PATCH 2/2] net: include: mii: Refactor: Use BIT() for ADVERTISE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52b9e3f4-8dd4-4696-9a47-0dc4eb59c013@prolan.hu>
Date: Wed, 5 Jun 2024 16:47:27 +0200
From: Csókás Bence <csokas.bence@...lan.hu>
To: Vladimir Oltean <olteanv@...il.com>
CC: <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<trivial@...nel.org>, Andrew Lunn <andrew@...n.ch>, Heiner Kallweit
	<hkallweit1@...il.com>, Russell King <linux@...linux.org.uk>
Subject: Re: [RFC PATCH 2/2] net: include: mii: Refactor: Use BIT() for
 ADVERTISE_* bits

Hi!

On 6/5/24 16:13, Vladimir Oltean wrote:
> On Wed, Jun 05, 2024 at 02:16:49PM +0200, Csókás, Bence wrote:
>> Replace hex values with BIT() and GENMASK() for readability
>>
>> Cc: trivial@...nel.org
>>
>> Signed-off-by: "Csókás, Bence" <csokas.bence@...lan.hu>
>> ---
> 
> You can't use BIT() and GENMASK() in headers exported to user space.
> 
> I mean you can, but the BIT() and GENMASK() macros themselves aren't
> exported to user space, and you would break any application which used
> values dependent on them.
> 

I thought the vDSO headers (which currently hold the definition for 
`BIT()`) *are* exported. Though `GENMASK()`, and the headers which would 
normally include vdso/bits.h, might not be... But then again, is 
uapi/linux/mii.h itself even exported? And if so, why aren't these 
macros? Is there any reason _not_ to export the entire linux/bits.h?

Bence