linux-kernel - Re: [PATCH v5 01/11] of/platform: Allow overlays to create platform devices from the root node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <171763126482.3452193.1706263155906513076.robh@kernel.org>
Date: Wed, 5 Jun 2024 17:47:47 -0600
From: "Rob Herring (Arm)" <robh@...nel.org>
To: Stephen Boyd <sboyd@...nel.org>
Cc: Daniel Latypov <dlatypov@...gle.com>,
	Saravana Kannan <saravanak@...gle.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
	linux-kernel@...r.kernel.org,
	Christian Marangi <ansuelsmth@...il.com>,
	devicetree@...r.kernel.org, Rae Moar <rmoar@...gle.com>,
	Conor Dooley <conor+dt@...nel.org>,
	Maxime Ripard <maxime@...no.tech>, linux-clk@...r.kernel.org,
	linux-kselftest@...r.kernel.org, David Gow <davidgow@...gle.com>,
	"Rafael J . Wysocki" <rafael@...nel.org>, patches@...ts.linux.dev,
	Michael Turquette <mturquette@...libre.com>,
	kunit-dev@...glegroups.com,
	Brendan Higgins <brendan.higgins@...ux.dev>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH v5 01/11] of/platform: Allow overlays to create platform
 devices from the root node


On Mon, 03 Jun 2024 15:37:58 -0700, Stephen Boyd wrote:
> We'd like to apply overlays to the root node in KUnit so we can test
> platform devices created as children of the root node.
> 
> On some architectures (powerpc), the root node isn't marked with
> OF_POPULATED_BUS. If an overlay tries to modify the root node on these
> platforms it will fail, while on other platforms, such as ARM, it will
> succeed. This is because the root node is marked with OF_POPULATED_BUS
> by of_platform_default_populate_init() calling
> of_platform_default_populate() with NULL as the first argument.
> 
> Loosen the requirement here so that platform devices can be created for
> nodes created as children of the root node via DT overlays even if the
> platform bus wasn't populated for the root node.
> 
> Cc: Rob Herring <robh@...nel.org>
> Cc: Saravana Kannan <saravanak@...gle.com>
> Signed-off-by: Stephen Boyd <sboyd@...nel.org>
> ---
>  drivers/of/platform.c | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
> 

Reviewed-by: Rob Herring (Arm) <robh@...nel.org>