linux-kernel - Re: [PATCH RFC v3 6/9] arm64: boot: dts: sm8650: Add board-id

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <451963a6-74ab-4654-a9db-c6f5e2d1b28e@linaro.org>
Date: Wed, 5 Jun 2024 10:18:19 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Elliot Berman <quic_eberman@...cinc.com>, Rob Herring
 <robh+dt@...nel.org>, Frank Rowand <frowand.list@...il.com>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
 Conor Dooley <conor+dt@...nel.org>, Bjorn Andersson <andersson@...nel.org>,
 Konrad Dybcio <konrad.dybcio@...aro.org>
Cc: Amrit Anand <quic_amrianan@...cinc.com>,
 Peter Griffin <peter.griffin@...aro.org>,
 Caleb Connolly <caleb.connolly@...aro.org>, Andy Gross <agross@...nel.org>,
 Doug Anderson <dianders@...omium.org>, Simon Glass <sjg@...omium.org>,
 Chen-Yu Tsai <wenst@...omium.org>, Julius Werner <jwerner@...omium.org>,
 "Humphreys, Jonathan" <j-humphreys@...com>,
 Sumit Garg <sumit.garg@...aro.org>, Jon Hunter <jonathanh@...dia.org>,
 Michal Simek <michal.simek@....com>, boot-architecture@...ts.linaro.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH RFC v3 6/9] arm64: boot: dts: sm8650: Add board-id

On 21/05/2024 20:38, Elliot Berman wrote:
> Add board-id to match sm8650 MTPs and QRDs.
> 
> Signed-off-by: Elliot Berman <quic_eberman@...cinc.com>

Please use subject prefixes matching the subsystem. You can get them for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching. For bindings, the preferred subjects are
explained here:
https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters

> ---
>  arch/arm64/boot/dts/qcom/sm8650-mtp.dts | 6 ++++++
>  arch/arm64/boot/dts/qcom/sm8650-qrd.dts | 6 ++++++
>  2 files changed, 12 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sm8650-mtp.dts b/arch/arm64/boot/dts/qcom/sm8650-mtp.dts
> index be133a3d5cbe..ceaf7cc270af 100644
> --- a/arch/arm64/boot/dts/qcom/sm8650-mtp.dts
> +++ b/arch/arm64/boot/dts/qcom/sm8650-mtp.dts
> @@ -5,6 +5,7 @@
>  
>  /dts-v1/;
>  
> +#include <dt-bindings/arm/qcom,ids.h>
>  #include <dt-bindings/regulator/qcom,rpmh-regulator.h>
>  #include "sm8650.dtsi"
>  #include "pm8010.dtsi"
> @@ -28,6 +29,11 @@ chosen {
>  		stdout-path = "serial0:115200n8";
>  	};
>  
> +	board-id {
> +		qcom,soc = <QCOM_ID_SM8650>;
> +		qcom,platform = <QCOM_BOARD_ID_MTP>;

I don't see a single benefit of this. This duplicates compatible and
brings absolutely no new information for the bootloaders.


Best regards,
Krzysztof