linux-kernel - Re: [PATCH RFC v3 8/9] arm64: boot: dts: qcom: sm8550: Split into overlays

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 5 Jun 2024 10:20:12 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Elliot Berman <quic_eberman@...cinc.com>, Rob Herring
 <robh+dt@...nel.org>, Frank Rowand <frowand.list@...il.com>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
 Conor Dooley <conor+dt@...nel.org>, Bjorn Andersson <andersson@...nel.org>,
 Konrad Dybcio <konrad.dybcio@...aro.org>
Cc: Amrit Anand <quic_amrianan@...cinc.com>,
 Peter Griffin <peter.griffin@...aro.org>,
 Caleb Connolly <caleb.connolly@...aro.org>, Andy Gross <agross@...nel.org>,
 Doug Anderson <dianders@...omium.org>, Simon Glass <sjg@...omium.org>,
 Chen-Yu Tsai <wenst@...omium.org>, Julius Werner <jwerner@...omium.org>,
 "Humphreys, Jonathan" <j-humphreys@...com>,
 Sumit Garg <sumit.garg@...aro.org>, Jon Hunter <jonathanh@...dia.org>,
 Michal Simek <michal.simek@....com>, boot-architecture@...ts.linaro.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH RFC v3 8/9] arm64: boot: dts: qcom: sm8550: Split into
 overlays

On 21/05/2024 20:38, Elliot Berman wrote:
>  
> +/dts-v1/;
> +
> +#include <dt-bindings/arm/qcom,ids.h>
>  #include <dt-bindings/clock/qcom,rpmh.h>
>  #include <dt-bindings/clock/qcom,sm8450-videocc.h>
>  #include <dt-bindings/clock/qcom,sm8550-camcc.h>
> @@ -32,6 +35,11 @@ / {
>  
>  	chosen { };
>  
> +	board_id: board-id {
> +		qcom,soc-version = <QCOM_ID_SM8550 QCOM_SOC_REVISION(1)>,
> +				   <QCOM_ID_SM8550 QCOM_SOC_REVISION(2)>;
> +	};


I don't see how does it help to understand usage of board-id. You list
all possible revisions, right? So this is entirely redundant.

Best regards,
Krzysztof