linux-kernel - Re: [PATCH v3 2/8] EDAC/amd64: Check return value of amd_smn

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240605094700.GVZmA0FK-8GcYsVdpm@fat_crate.local>
Date: Wed, 5 Jun 2024 11:47:00 +0200
From: Borislav Petkov <bp@...en8.de>
To: Yazen Ghannam <yazen.ghannam@....com>
Cc: Guenter Roeck <linux@...ck-us.net>, x86@...nel.org,
	Mario Limonciello <mario.limonciello@....com>,
	linux-edac@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-hwmon@...r.kernel.org
Subject: Re: [PATCH v3 2/8] EDAC/amd64: Check return value of amd_smn_read()

On Thu, May 23, 2024 at 01:26:53PM -0500, Yazen Ghannam wrote:
> Check the return value of amd_smn_read() before saving a value. This
> ensures invalid values aren't saved. The struct umc instance is
> initialized to 0 during memory allocation. Therefore, a bad read will
> keep the value as 0 providing the expected Read-as-Zero behavior.
> 
> Furthermore, the __must_check attribute will be added to amd_smn_read().
> Therefore, this change is required to avoid compile-time warnings.
> 
> Signed-off-by: Yazen Ghannam <yazen.ghannam@....com>
> Reviewed-by: Mario Limonciello <mario.limonciello@....com>
> Cc: stable@...r.kernel.org

Not really stable material. Zapped and applied.

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette