linux-kernel - Re: [PATCH v2 5/5] usb: host: xhci-plat: Add support for XHCI_WRITE_64_HI_LO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 5 Jun 2024 10:50:10 +0900
From: Jung Daehwan <dh10.jung@...sung.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Rob Herring
	<robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
	<conor+dt@...nel.org>, Thinh Nguyen <Thinh.Nguyen@...opsys.com>, Mathias
	Nyman <mathias.nyman@...el.com>, Felipe Balbi <balbi@...nel.org>, "open
 list:USB SUBSYSTEM" <linux-usb@...r.kernel.org>, "open list:OPEN FIRMWARE
 AND FLATTENED DEVICE TREE BINDINGS" <devicetree@...r.kernel.org>, open list
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 5/5] usb: host: xhci-plat: Add support for
 XHCI_WRITE_64_HI_LO_QUIRK

On Tue, Jun 04, 2024 at 08:20:44AM +0200, Krzysztof Kozlowski wrote:
> On 03/06/2024 10:51, Jung Daehwan wrote:
> >>>>>  
> >>>>> +		if (device_property_read_bool(tmpdev, "write-64-hi-lo-quirk"))
> >>>>> +			xhci->quirks |= XHCI_WRITE_64_HI_LO;
> >>>>
> >>>> Where is any user of this property (DTS)? Just to clarify: your
> >>>> downstream does not matter really.
> >>>>
> >>>
> >>> This is set by dwc3 parent node by software node.
> >>>
> >>> [PATCH v2 1/5] dt-bindings: usb: snps,dwc3: Add 'snps,xhci-write-64-hi-lo-quirk' quirk
> >>> https://lore.kernel.org/r/1717135657-120818-2-git-send-email-dh10.jung@samsung.com/
> >>
> >> This is not a patch to DTS.
> >>
> >>
> > 
> > This is set by software node from dwc3. That's why I think this patch doesn't
> > need DTS patch. I would add DTS patch in dwc3 not xhci if it's needed.
> > 
> 
> What?
> 
> I asked you question which upstream SoC (link to DTS) uses it, and you
> say that "no need for DTS patch"? That's not an answer.
> 
> Best regards,
> Krzysztof
> 
> 

I'm sorry I didn't get your point. I've been working on Exynos SoC.
But there's no upstream user of this property yet in this patchset.

Best Regards,
Jung Daehwan