linux-kernel - [PATCH] modpost: bypass module description test on vmlinux.o

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date: Fri, 7 Jun 2024 14:42:43 -0700
From: Jeff Johnson <quic_jjohnson@...cinc.com>
To: Masahiro Yamada <masahiroy@...nel.org>,
        Nathan Chancellor
	<nathan@...nel.org>,
        Nicolas Schier <nicolas@...sle.eu>,
        Vincenzo Palazzo
	<vincenzopalazzodev@...il.com>
CC: <linux-kbuild@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <kernel-janitors@...r.kernel.org>,
        Jeff Johnson <quic_jjohnson@...cinc.com>
Subject: [PATCH] modpost: bypass module description test on vmlinux.o

When building modules with W=1, modpost will warn if a module is
missing a MODULE_DESCRIPTION. Unfortunately, it also performs this
test on vmlinux.o:

WARNING: modpost: missing MODULE_DESCRIPTION() in vmlinux.o

Relocate the logic so that the test is not performed on vmlinux.o.

Fixes: 1fffe7a34c89 ("script: modpost: emit a warning when the description is missing")
Signed-off-by: Jeff Johnson <quic_jjohnson@...cinc.com>
---
 scripts/mod/modpost.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c
index 937294ff164f..f48d72d22dc2 100644
--- a/scripts/mod/modpost.c
+++ b/scripts/mod/modpost.c
@@ -1647,10 +1647,11 @@ static void read_symbols(const char *modname)
 			namespace = get_next_modinfo(&info, "import_ns",
 						     namespace);
 		}
+
+		if (extra_warn && !get_modinfo(&info, "description"))
+			warn("missing MODULE_DESCRIPTION() in %s\n", modname);
 	}
 
-	if (extra_warn && !get_modinfo(&info, "description"))
-		warn("missing MODULE_DESCRIPTION() in %s\n", modname);
 	for (sym = info.symtab_start; sym < info.symtab_stop; sym++) {
 		symname = remove_dot(info.strtab + sym->st_name);
 

---
base-commit: 19ca0d8a433ff37018f9429f7e7739e9f3d3d2b4
change-id: 20240607-md-scripts-mod-7f7ff091e02b