linux-kernel - Re: [PATCH v6 3/9] iio: adc: ad_sigma_delta: add disable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <329d2f78f55f7df1f03d8581cd108b51f01da86a.camel@gmail.com>
Date: Fri, 07 Jun 2024 12:16:06 +0200
From: Nuno Sá <noname.nuno@...il.com>
To: "Ceclan, Dumitru" <mitrutzceclan@...il.com>, dumitru.ceclan@...log.com
Cc: Lars-Peter Clausen <lars@...afoo.de>, Michael Hennerich
 <Michael.Hennerich@...log.com>, Jonathan Cameron <jic23@...nel.org>, Rob
 Herring <robh@...nel.org>, Krzysztof Kozlowski
 <krzysztof.kozlowski+dt@...aro.org>, Conor Dooley <conor+dt@...nel.org>,
 David Lechner <dlechner@...libre.com>,  linux-iio@...r.kernel.org,
 devicetree@...r.kernel.org,  linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6 3/9] iio: adc: ad_sigma_delta: add disable_one
 callback

On Fri, 2024-06-07 at 12:29 +0300, Ceclan, Dumitru wrote:
> On 07/06/2024 12:02, Nuno Sá wrote:
> > On Thu, 2024-06-06 at 19:07 +0300, Dumitru Ceclan via B4 Relay wrote:
> > > From: Dumitru Ceclan <dumitru.ceclan@...log.com>
> > > 
> > > Sigma delta ADCs with a sequencer need to disable the previously enabled
> > > channel when reading using ad_sigma_delta_single_conversion(). This was
> > > done manually in drivers for devices with sequencers.
> > > 
> > > This patch implements handling of single channel disabling after a
> > > single conversion.
> > > 
> > > Signed-off-by: Dumitru Ceclan <dumitru.ceclan@...log.com>
> > > ---
> > 
> > You could have this done in separate patches... Oh well, this is simple
> > enough
> > that I don't care much.
> > 
> > Reviewed-by: Nuno Sa <nuno.sa@...log.com>
> > 
> 
> Separate patches would break driver functionality then fix it.
> The drivers would not probe as disable_one() callback is missing.
> 
> This would have been alright?
> 

No, it's not... I mean, you could also only enforce the disable_one() presence
after updating all users but I agree this is simple enough to go in one patch.

- Nuno Sá