linux-kernel - Re: [PATCH 1/1] hwrng: amd - Convert PCIBIOS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZmL0m6xaL9JXb2mu@gondor.apana.org.au>
Date: Fri, 7 Jun 2024 19:52:59 +0800
From: Herbert Xu <herbert@...dor.apana.org.au>
To: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
Cc: Olivia Mackall <olivia@...enic.com>, Michael Buesch <mb@...sch.de>,
	Andrew Morton <akpm@...l.org>, linux-crypto@...r.kernel.org,
	linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH 1/1] hwrng: amd - Convert PCIBIOS_* return codes to errnos

On Mon, May 27, 2024 at 04:26:15PM +0300, Ilpo Järvinen wrote:
> amd_rng_mod_init() uses pci_read_config_dword() that returns PCIBIOS_*
> codes. The return code is then returned as is but amd_rng_mod_init() is
> a module_init() function that should return normal errnos.
> 
> Convert PCIBIOS_* returns code using pcibios_err_to_errno() into normal
> errno before returning it.
> 
> Fixes: 96d63c0297cc ("[PATCH] Add AMD HW RNG driver")
> Cc: stable@...r.kernel.org
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
> ---
>  drivers/char/hw_random/amd-rng.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt