linux-kernel - Re: [PATCH 6.6 000/741] 6.6.33-rc2 review

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240610-scabby-bruising-110970760c41@wendy>
Date: Mon, 10 Jun 2024 08:26:10 +0100
From: Conor Dooley <conor.dooley@...rochip.com>
To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
CC: Ron Economos <re@...z.net>, Pavel Machek <pavel@...x.de>,
	<stable@...r.kernel.org>, <patches@...ts.linux.dev>,
	<linux-kernel@...r.kernel.org>, <torvalds@...ux-foundation.org>,
	<akpm@...ux-foundation.org>, <linux@...ck-us.net>, <shuah@...nel.org>,
	<patches@...nelci.org>, <lkft-triage@...ts.linaro.org>,
	<jonathanh@...dia.com>, <f.fainelli@...il.com>, <sudipm.mukherjee@...il.com>,
	<srw@...dewatkins.net>, <rwarsow@....de>, <conor@...nel.org>,
	<allen.lkml@...il.com>, <broonie@...nel.org>
Subject: Re: [PATCH 6.6 000/741] 6.6.33-rc2 review

On Mon, Jun 10, 2024 at 08:28:29AM +0200, Greg Kroah-Hartman wrote:
> On Sun, Jun 09, 2024 at 11:21:55PM -0700, Ron Economos wrote:
> > On 6/9/24 12:34 PM, Pavel Machek wrote:
> > > Hi!
> > > 
> > > > This is the start of the stable review cycle for the 6.6.33 release.
> > > > There are 741 patches in this series, all will be posted as a response
> > > > to this one.  If anyone has any issues with these being applied, please
> > > > let me know.
> > > 6.6 seems to have build problem on risc-v:

> > > arch/riscv/kernel/suspend.c:14:66: error: 'RISCV_ISA_EXT_XLINUXENVCFG' undeclared (first use in this function); did you mean 'RISCV_ISA_EXT_ZIFENCEI'?
> > > 694
> > >     14 |         if (riscv_cpu_has_extension_unlikely(smp_processor_id(), RISCV_ISA_EXT_XLINUXENVCFG))
> > > 695
> > >        |                                                                  ^~~~~~~~~~~~~~~~~~~~~~~~~~
> > > 696
> > >        |                                                                  RISCV_ISA_EXT_ZIFENCEI

> > > https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/jobs/7053222239
> > > https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/pipelines/1324369118
> > > 
> > > No problems detected on 6.8-stable and 6.1-stable.
> > > 
> > > Best regards,
> > > 								Pavel
> > 
> > I'm seeing the same thing here. Somehow some extra patches got slipped in
> > between rc1 and rc2. The new patches for RISC-V are:
> > 
> > Samuel Holland <samuel.holland@...ive.com>
> >     riscv: Save/restore envcfg CSR during CPU suspend
> > 
> > commit 88b55a586b87994a33e0285c9e8881485e9b77ea
> > 
> > Samuel Holland <samuel.holland@...ive.com>
> >     riscv: Fix enabling cbo.zero when running in M-mode
> > 
> > commit 8c6e096cf527d65e693bfbf00aa6791149c58552
> > 
> > The first patch "riscv: Save/restore envcfg CSR during CPU suspend" causes
> > the build failure.
> > 
> > 
> 
> Yes, these were added because they were marked as fixes for other
> commits in the series.  I'll unwind them all now as something is going
> wrong...

Really we should just backport this envcfg handling to stable, this
isn't the first (and won't be the last) issue it'll cause. I'll put a
backport of it on my todo list cos I think last time around it couldn't
be cherrypicked.

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)