[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAMuHMdXOHHsyvZKME75qHk0M9sVf6A8EnA0YwJpbDSHt48tTVw@mail.gmail.com>
Date: Mon, 10 Jun 2024 14:03:25 +0200
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: Wolfram Sang <wsa+renesas@...g-engineering.com>
Cc: linux-renesas-soc@...r.kernel.org, Andy Whitcroft <apw@...onical.com>,
Joe Perches <joe@...ches.com>, Dwaipayan Ray <dwaipayanray1@...il.com>,
Lukas Bulwahn <lukas.bulwahn@...il.com>, Andrew Morton <akpm@...ux-foundation.org>,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] checkpatch: really skip LONG_LINE_* when LONG_LINE is ignored
Hi Wolfram,
On Mon, Jun 10, 2024 at 1:46 PM Wolfram Sang
<wsa+renesas@...g-engineering.com> wrote:
> For this to happen, all types must be set to "show". So, AND is needed
> for the flags, not OR.
>
> Fixes: 47e0c88b37a5 ("checkpatch: categorize some long line length checks")
> Signed-off-by: Wolfram Sang <wsa+renesas@...g-engineering.com>
Thanks for your patch!
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -3858,7 +3858,7 @@ sub process {
> }
>
> if ($msg_type ne "" &&
> - (show_type("LONG_LINE") || show_type($msg_type))) {
> + (show_type("LONG_LINE") && show_type($msg_type))) {
I don't know if the change in logic is correct, but if it is, you
probably want to remove one set of parentheses:
A && (B && C) => A && B && C
> my $msg_level = \&WARN;
> $msg_level = \&CHK if ($file);
> &{$msg_level}($msg_type,
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Powered by blists - more mailing lists