linux-kernel - Re: [PATCH v2 7/8] thermal/debugfs: Move some statements from under thermal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d497da6f-adc4-4141-87bf-5b3e2fc0e926@linaro.org>
Date: Mon, 10 Jun 2024 15:27:15 +0200
From: Daniel Lezcano <daniel.lezcano@...aro.org>
To: "Rafael J. Wysocki" <rjw@...ysocki.net>,
 Linux PM <linux-pm@...r.kernel.org>
Cc: LKML <linux-kernel@...r.kernel.org>, "Rafael J. Wysocki"
 <rafael@...nel.org>, Lukasz Luba <lukasz.luba@....com>
Subject: Re: [PATCH v2 7/8] thermal/debugfs: Move some statements from under
 thermal_dbg->lock

On 28/05/2024 16:59, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
> 
> The tz_dbg local variable assignments in thermal_debug_tz_trip_up(),
> thermal_debug_tz_trip_down(), and thermal_debug_update_trip_stats()
> need not be carried out under thermal_dbg->lock, 

May be explain why ?

> so move them from
> under that lock (to avoid possible future confusion).
> 
> While at it, reorder local variable definitions in
> thermal_debug_tz_trip_up() for more clarity.
> 
> No functional impact.
> 
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com>

Acked-by: Daniel Lezcano <daniel.lezcano@...aro.org>

-- 
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog