linux-kernel - Re: [PATCH] pwm: add missing MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 10 Jun 2024 07:44:16 -0700
From: Jeff Johnson <quic_jjohnson@...cinc.com>
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
        Uwe Kleine-König <ukleinek@...nel.org>,
        Shawn Guo
	<shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Pengutronix
 Kernel Team <kernel@...gutronix.de>,
        Fabio Estevam <festevam@...il.com>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        Alim Akhtar <alim.akhtar@...sung.com>,
        Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@...hiba.co.jp>,
        Matthias Brugger
	<matthias.bgg@...il.com>
CC: <linux-pwm@...r.kernel.org>, <imx@...ts.linux.dev>,
        <linux-arm-kernel@...ts.infradead.org>, <linux-kernel@...r.kernel.org>,
        <linux-samsung-soc@...r.kernel.org>,
        <linux-mediatek@...ts.infradead.org>,
        <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH] pwm: add missing MODULE_DESCRIPTION() macros

On 6/10/2024 1:06 AM, AngeloGioacchino Del Regno wrote:
> Il 07/06/24 18:02, Jeff Johnson ha scritto:
>> make allmodconfig && make W=1 C=1 reports:
>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/pwm/pwm-imx1.o
>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/pwm/pwm-imx27.o
>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/pwm/pwm-intel-lgm.o
>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/pwm/pwm-mediatek.o
>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/pwm/pwm-pxa.o
>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/pwm/pwm-samsung.o
>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/pwm/pwm-spear.o
>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/pwm/pwm-visconti.o
>>
>> Add the missing invocations of the MODULE_DESCRIPTION() macro.
>>
>> Signed-off-by: Jeff Johnson <quic_jjohnson@...cinc.com>
>> ---
>> This addresses all of the issues in driver/pwm
>>
>> Let me know if you want any of the individual module changes
>> segregated into separate patches.
>> ---
>>   drivers/pwm/pwm-imx1.c      | 1 +
>>   drivers/pwm/pwm-imx27.c     | 1 +
>>   drivers/pwm/pwm-intel-lgm.c | 1 +
>>   drivers/pwm/pwm-mediatek.c  | 1 +
>>   drivers/pwm/pwm-pxa.c       | 1 +
>>   drivers/pwm/pwm-samsung.c   | 1 +
>>   drivers/pwm/pwm-spear.c     | 1 +
>>   drivers/pwm/pwm-visconti.c  | 1 +
>>   8 files changed, 8 insertions(+)
>>
> 
> ..snip..
> 
>> diff --git a/drivers/pwm/pwm-mediatek.c b/drivers/pwm/pwm-mediatek.c
>> index 19a87873ad60..0b5d68a90e83 100644
>> --- a/drivers/pwm/pwm-mediatek.c
>> +++ b/drivers/pwm/pwm-mediatek.c
>> @@ -395,4 +395,5 @@ static struct platform_driver pwm_mediatek_driver = {
>>   module_platform_driver(pwm_mediatek_driver);
>>   
>>   MODULE_AUTHOR("John Crispin <blogic@...nwrt.org>");
>> +MODULE_DESCRIPTION("MediaTek Pulse Width Modulator driver");
> 
> MediaTek SoCs have got two different PWM IPs, one of which is used exclusively
> for the Display PWM, and it is located in the DDP block.
> 
> So, there are two PWM IPs in one SoC:
>   - A general purpose PWM IP
>   - A DDP PWM IP
> 
> This driver is for the general purpose PWM IP.. so, please, can we change this
> to "MediaTek general purpose Pulse Width Modulator driver"?
> 
> After which,
> 
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
> 
>>   MODULE_LICENSE("GPL v2");
> 
Sure, I'll update these in v2