linux-kernel - Re: [PATCH] pwm: add missing MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e730c786-86b9-4362-986d-cfe37ef33753@quicinc.com>
Date: Mon, 10 Jun 2024 07:51:39 -0700
From: Jeff Johnson <quic_jjohnson@...cinc.com>
To: Uwe Kleine-König <u.kleine-koenig@...libre.com>,
        AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
CC: Shawn Guo <shawnguo@...nel.org>, Sascha Hauer <s.hauer@...gutronix.de>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Fabio Estevam
	<festevam@...il.com>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        Alim Akhtar
	<alim.akhtar@...sung.com>,
        Nobuhiro Iwamatsu
	<nobuhiro1.iwamatsu@...hiba.co.jp>,
        Matthias Brugger
	<matthias.bgg@...il.com>,
        <linux-pwm@...r.kernel.org>, <imx@...ts.linux.dev>,
        <linux-arm-kernel@...ts.infradead.org>, <linux-kernel@...r.kernel.org>,
        <linux-samsung-soc@...r.kernel.org>,
        <linux-mediatek@...ts.infradead.org>,
        <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH] pwm: add missing MODULE_DESCRIPTION() macros

On 6/10/2024 2:05 AM, Uwe Kleine-König wrote:
> Hello,
> 
> On Mon, Jun 10, 2024 at 10:06:49AM +0200, AngeloGioacchino Del Regno wrote:
>> Il 07/06/24 18:02, Jeff Johnson ha scritto:
>>> [...]
>>> diff --git a/drivers/pwm/pwm-mediatek.c b/drivers/pwm/pwm-mediatek.c
>>> index 19a87873ad60..0b5d68a90e83 100644
>>> --- a/drivers/pwm/pwm-mediatek.c
>>> +++ b/drivers/pwm/pwm-mediatek.c
>>> @@ -395,4 +395,5 @@ static struct platform_driver pwm_mediatek_driver = {
>>>   module_platform_driver(pwm_mediatek_driver);
>>>   MODULE_AUTHOR("John Crispin <blogic@...nwrt.org>");
>>> +MODULE_DESCRIPTION("MediaTek Pulse Width Modulator driver");
>>
>> MediaTek SoCs have got two different PWM IPs, one of which is used exclusively
>> for the Display PWM, and it is located in the DDP block.
>>
>> So, there are two PWM IPs in one SoC:
>>  - A general purpose PWM IP
>>  - A DDP PWM IP
>>
>> This driver is for the general purpose PWM IP.. so, please, can we change this
>> to "MediaTek general purpose Pulse Width Modulator driver"?
>>
>> After which,
>>
>> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
> 
> Looks like a reasonable request.
> 
> @Jeff: Can you please resend with the suggested change, I dropped the
> patch from for-next now.

No problem, v2 sent.

/jeff