linux-kernel - Re: [v4,2/2] hwmon: add MP2891 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 10 Jun 2024 09:23:18 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: Noah Wang <noahwang.wang@...look.com>, robh@...nel.org,
 krzk+dt@...nel.org, conor+dt@...nel.org, jdelvare@...e.com
Cc: corbet@....net, Delphine_CC_Chiu@...ynn.com, peteryin.openbmc@...il.com,
 javier.carrasco.cruz@...il.com, patrick.rudolph@...ements.com,
 luca.ceresoli@...tlin.com, chou.cosmo@...il.com, bhelgaas@...gle.com,
 lukas@...ner.de, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-hwmon@...r.kernel.org, linux-doc@...r.kernel.org,
 linux-i2c@...r.kernel.org
Subject: Re: [v4,2/2] hwmon: add MP2891 driver

On 6/3/24 03:53, Noah Wang wrote:
> Add support for MPS VR controller mp2891. This driver exposes
> telemetry and limit value readings and writtings.
> 
> Signed-off-by: Noah Wang <noahwang.wang@...look.com>
> ---
[ ... ]

> +
> +static int mp2891_identify(struct i2c_client *client, struct pmbus_driver_info *info)
> +{
> +	int ret;
> +
> +	/* Identify vout scale for rail 1. */
> +	ret = mp2891_identify_vout_scale(client, info, 0);
> +	if (ret < 0)
> +		return ret;
> +
> +	/* Identify vout scale for rail 2. */
> +	ret = mp2891_identify_vout_scale(client, info, 1);
> +	if (ret < 0)
> +		return ret;
> +
> +	/* Identify iout scale for rail 1. */
> +	ret = mp2891_identify_iout_scale(client, info, 0);
> +	if (ret < 0)
> +		return ret;
> +
> +	/* Identify iout scale for rail 2. */
> +	ret = mp2891_identify_iout_scale(client, info, 1);
> +	if (ret < 0)
> +		return ret;
> +
> +	return ret;

	return mp2891_identify_iout_scale(...);

Guenter