linux-kernel - Re: [PATCH v3 1/1] dt-bindings: mmc: Convert fsl-esdhc.txt to yaml

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Tue, 11 Jun 2024 10:58:21 -0400
From: Frank Li <Frank.li@....com>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: conor+dt@...nel.org, devicetree@...r.kernel.org, imx@...ts.linux.dev,
	krzk+dt@...nel.org, linux-kernel@...r.kernel.org,
	linux-mmc@...r.kernel.org, robh@...nel.org, ulf.hansson@...aro.org
Subject: Re: [PATCH v3 1/1] dt-bindings: mmc: Convert fsl-esdhc.txt to yaml

On Tue, Jun 11, 2024 at 08:44:51AM +0200, Krzysztof Kozlowski wrote:
> On 10/06/2024 16:33, Frank Li wrote:
> > On Mon, Jun 10, 2024 at 02:29:57PM +0200, Krzysztof Kozlowski wrote:
> >> On 06/06/2024 08:44, Krzysztof Kozlowski wrote:
> >>> On 05/06/2024 20:50, Frank Li wrote:
> >>>> Convert layerscape fsl-esdhc binding doc from txt to yaml format.
> >>>>
> >>>> Addtional change during convert:
> >>>> - Deprecate "sdhci,wp-inverted", "sdhci,1-bit-only".
> >>>> - Add "reg" and "interrupts" property.
> >>>> - Change example "sdhci@...00" to "mmc@...00".
> >>>> - Compatible string require fsl,<chip>-esdhc followed by fsl,esdhc to match
> >>>> most existed dts file.
> >>>> - Set clock-frequency to 100mhz in example.
> >>>>
> >>>
> >>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> >>
> >> Or not... are you sure that DTS validates? Did you test it? kbuild has a
> >> bit different opinion.
> > 
> > Need additional patch to fix this DTS warnings. It needs convert to yaml
> > firstly. If you like, I can create big patch set to fix all emmc related
> > warnings.
> 
> We kind of been here... I raise the problem and you answer with
> something unspecific requiring me to dig more to prove my point. I am
> not going to play more of that game.
> 
> Did you analyze the errors?

Yes, only strange thing is "voltages-ranges".  mmc-spi-slot.yaml impact the
result. I don't know why mmc-spi-slot.yaml apply to 'ls' platform dts. Any
way, below patch can fix this problem.

diff --git a/Documentation/devicetree/bindings/mmc/mmc-spi-slot.yaml b/Documentation/devicetree/bindings/mmc/mmc-spi-slot.yaml
index 36acc40c7d181..51cf2e4270252 100644
--- a/Documentation/devicetree/bindings/mmc/mmc-spi-slot.yaml
+++ b/Documentation/devicetree/bindings/mmc/mmc-spi-slot.yaml
@@ -27,7 +27,7 @@ properties:
     maxItems: 1
 
   voltage-ranges:
-    $ref: /schemas/types.yaml#/definitions/uint32-array
+    $ref: /schemas/types.yaml#/definitions/uint32-matrix
     description: |
       Two cells are required, first cell specifies minimum slot voltage (mV),
       second cell specifies maximum slot voltage (mV).
@@ -38,6 +38,8 @@ properties:
       - description: |
           value for maximum slot voltage in mV
         default: 3400
+    minItems: 1
+    maxItems: 8


I will send out all patches soon.


> 
> Best regards,
> Krzysztof
>