| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Tue, 11 Jun 2024 16:22:56 +0100
From: Teddy Engel <engel.teddy@...il.com>
To: Philipp Hortmann <philipp.g.hortmann@...il.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
linux-staging@...ts.linux.dev,
linux-kernel@...r.kernel.org
Cc: Teddy Engel <engel.teddy@...il.com>
Subject: [PATCH] staging: vt6656: Fix checkpatch unnecessary parentheses
Remove unnecessary parentheses - according to checkpatch.pl strict
Signed-off-by: Teddy Engel <engel.teddy@...il.com>
---
drivers/staging/vt6656/TODO | 2 +-
drivers/staging/vt6656/baseband.c | 8 ++++----
drivers/staging/vt6656/main_usb.c | 4 ++--
drivers/staging/vt6656/usbpipe.c | 8 ++++----
4 files changed, 11 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/vt6656/TODO b/drivers/staging/vt6656/TODO
index e154b2f3b247..507b7aec9f14 100644
--- a/drivers/staging/vt6656/TODO
+++ b/drivers/staging/vt6656/TODO
@@ -11,7 +11,7 @@ TODO:
- switch to use LIB80211
- switch to use MAC80211
- use kernel coding style
-- checkpatch.pl fixes
+- checkpatch.pl fixes -- done
- sparse fixes
- integrate with drivers/net/wireless
diff --git a/drivers/staging/vt6656/baseband.c b/drivers/staging/vt6656/baseband.c
index ad7b963f0d98..c981fc75a030 100644
--- a/drivers/staging/vt6656/baseband.c
+++ b/drivers/staging/vt6656/baseband.c
@@ -230,8 +230,8 @@ int vnt_vt3184_init(struct vnt_private *priv)
dev_dbg(&priv->usb->dev, "RF Type %d\n", priv->rf_type);
- if ((priv->rf_type == RF_AL2230) ||
- (priv->rf_type == RF_AL2230S)) {
+ if (priv->rf_type == RF_AL2230 ||
+ priv->rf_type == RF_AL2230S) {
priv->bb_rx_conf = vnt_vt3184_al2230[10];
length = sizeof(vnt_vt3184_al2230);
addr = vnt_vt3184_al2230;
@@ -275,8 +275,8 @@ int vnt_vt3184_init(struct vnt_private *priv)
if (ret)
goto end;
- if ((priv->rf_type == RF_VT3226) ||
- (priv->rf_type == RF_VT3226D0)) {
+ if (priv->rf_type == RF_VT3226 ||
+ priv->rf_type == RF_VT3226D0) {
data = (priv->rf_type == RF_VT3226D0) ? 0x11 : 0x23;
ret = vnt_control_out_u8(priv, MESSAGE_REQUEST_MACREG,
diff --git a/drivers/staging/vt6656/main_usb.c b/drivers/staging/vt6656/main_usb.c
index 7bbed462f062..86085f3674c1 100644
--- a/drivers/staging/vt6656/main_usb.c
+++ b/drivers/staging/vt6656/main_usb.c
@@ -339,8 +339,8 @@ static int vnt_init_registers(struct vnt_private *priv)
/* load vt3266 calibration parameters in EEPROM */
if (priv->rf_type == RF_VT3226D0) {
- if ((priv->eeprom[EEP_OFS_MAJOR_VER] == 0x1) &&
- (priv->eeprom[EEP_OFS_MINOR_VER] >= 0x4)) {
+ if (priv->eeprom[EEP_OFS_MAJOR_VER] == 0x1 &&
+ priv->eeprom[EEP_OFS_MINOR_VER] >= 0x4) {
calib_tx_iq = priv->eeprom[EEP_OFS_CALIB_TX_IQ];
calib_tx_dc = priv->eeprom[EEP_OFS_CALIB_TX_DC];
calib_rx_iq = priv->eeprom[EEP_OFS_CALIB_RX_IQ];
diff --git a/drivers/staging/vt6656/usbpipe.c b/drivers/staging/vt6656/usbpipe.c
index d505b4b69ba4..42b2e0a0a431 100644
--- a/drivers/staging/vt6656/usbpipe.c
+++ b/drivers/staging/vt6656/usbpipe.c
@@ -287,7 +287,7 @@ static int vnt_rx_data(struct vnt_private *priv, struct vnt_rcb *ptr_rcb,
return false;
}
- if ((bytes_received > 2372) || (bytes_received <= 40)) {
+ if (bytes_received > 2372 || bytes_received <= 40) {
/* Frame Size error drop this packet.*/
dev_dbg(&priv->usb->dev, "------ WRONG Length 2\n");
return false;
@@ -299,9 +299,9 @@ static int vnt_rx_data(struct vnt_private *priv, struct vnt_rcb *ptr_rcb,
/* if SQ3 the range is 24~27, if no SQ3 the range is 20~23 */
/*Fix hardware bug => PLCP_Length error */
- if (((bytes_received - head->pay_load_len) > 27) ||
- ((bytes_received - head->pay_load_len) < 24) ||
- (bytes_received < head->pay_load_len)) {
+ if ((bytes_received - head->pay_load_len) > 27 ||
+ (bytes_received - head->pay_load_len) < 24 ||
+ bytes_received < head->pay_load_len) {
dev_dbg(&priv->usb->dev, "Wrong PLCP Length %x\n",
head->pay_load_len);
return false;
--
2.39.2
Powered by blists - more mailing lists