linux-kernel - Re: [PATCH] staging: vt6656: Fix checkpatch unnecessary parentheses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Wed, 12 Jun 2024 08:57:16 +0200
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Teddy Engel <engel.teddy@...il.com>
Cc: Philipp Hortmann <philipp.g.hortmann@...il.com>,
	linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: vt6656: Fix checkpatch unnecessary parentheses

On Tue, Jun 11, 2024 at 04:22:56PM +0100, Teddy Engel wrote:
> Remove unnecessary parentheses - according to checkpatch.pl strict
> 
> Signed-off-by: Teddy Engel <engel.teddy@...il.com>
> ---
>  drivers/staging/vt6656/TODO       | 2 +-
>  drivers/staging/vt6656/baseband.c | 8 ++++----
>  drivers/staging/vt6656/main_usb.c | 4 ++--
>  drivers/staging/vt6656/usbpipe.c  | 8 ++++----
>  4 files changed, 11 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/staging/vt6656/TODO b/drivers/staging/vt6656/TODO
> index e154b2f3b247..507b7aec9f14 100644
> --- a/drivers/staging/vt6656/TODO
> +++ b/drivers/staging/vt6656/TODO
> @@ -11,7 +11,7 @@ TODO:
>  - switch to use LIB80211
>  - switch to use MAC80211
>  - use kernel coding style
> -- checkpatch.pl fixes
> +- checkpatch.pl fixes -- done

When fixing something, you can just remove the line.

>  - sparse fixes
>  - integrate with drivers/net/wireless
>  
> diff --git a/drivers/staging/vt6656/baseband.c b/drivers/staging/vt6656/baseband.c
> index ad7b963f0d98..c981fc75a030 100644
> --- a/drivers/staging/vt6656/baseband.c
> +++ b/drivers/staging/vt6656/baseband.c
> @@ -230,8 +230,8 @@ int vnt_vt3184_init(struct vnt_private *priv)
>  
>  	dev_dbg(&priv->usb->dev, "RF Type %d\n", priv->rf_type);
>  
> -	if ((priv->rf_type == RF_AL2230) ||
> -	    (priv->rf_type == RF_AL2230S)) {
> +	if (priv->rf_type == RF_AL2230 ||
> +	    priv->rf_type == RF_AL2230S) {

Sorry, but no, please see the mailing list archives as to why I keep
rejecting these kinds of patches. checkpatch is wrong here.

greg k-h