linux-kernel - Re: [PATCH 08/14] scsi: fnic: Add functionality in fnic to support FDLS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f992c0f2-8f70-4dc0-b679-e522e3fd6101@suse.de>
Date: Wed, 12 Jun 2024 08:57:28 +0200
From: Hannes Reinecke <hare@...e.de>
To: Karan Tilak Kumar <kartilak@...co.com>, sebaddel@...co.com
Cc: arulponn@...co.com, djhawar@...co.com, gcboffa@...co.com,
 mkai2@...co.com, satishkh@...co.com, jejb@...ux.ibm.com,
 martin.petersen@...cle.com, linux-scsi@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH 08/14] scsi: fnic: Add functionality in fnic to support
 FDLS

On 6/10/24 23:50, Karan Tilak Kumar wrote:
> Add interfaces in fnic to use FDLS services.
> Modify link up and link down functionality to use FDLS.
> Replace existing interfaces to handle new functionality
> provided by FDLS.
> Modify data types of some data members to handle new
> functionality.
> Add processing of tports and handling of tports.
> 
> Reviewed-by: Sesidhar Baddela <sebaddel@...co.com>
> Reviewed-by: Arulprabhu Ponnusamy <arulponn@...co.com>
> Reviewed-by: Gian Carlo Boffa <gcboffa@...co.com>
> Signed-off-by: Karan Tilak Kumar <kartilak@...co.com>
> ---
>   drivers/scsi/fnic/fdls_disc.c |  74 +++++
>   drivers/scsi/fnic/fip.c       |  27 +-
>   drivers/scsi/fnic/fnic.h      |  20 +-
>   drivers/scsi/fnic/fnic_fcs.c  | 498 ++++++++++++++++++++++++----------
>   drivers/scsi/fnic/fnic_main.c |  10 +-
>   drivers/scsi/fnic/fnic_scsi.c | 127 +++++++--
>   6 files changed, 587 insertions(+), 169 deletions(-)
> 
This seems to not just _add_ the functionality to use FDLS, but rather 
_replace_ the existing functionality with FDLS.
IE it seems that after this change the driver will always do FDLS, 
causing a possible service interruption with existing setups.
Hmm?

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                  Kernel Storage Architect
hare@...e.de                                +49 911 74053 688
SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg
HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich