linux-kernel - Re: [PATCH] dt-bindings: reset: brcm,bcm63138-pmb: convert to yaml

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 10 Jun 2024 23:30:37 -0600
From: "Rob Herring (Arm)" <robh@...nel.org>
To: Kanak Shilledar <kanakshilledar@...il.com>
Cc: Philipp Zabel <p.zabel@...gutronix.de>, 
 Rafał Miłecki <rafal@...ecki.pl>, 
 Broadcom internal kernel review list <bcm-kernel-feedback-list@...adcom.com>, 
 William Zhang <william.zhang@...adcom.com>, 
 Kanak Shilledar <kanakshilledar111@...tonmail.com>, 
 Florian Fainelli <florian.fainelli@...adcom.com>, 
 Krzysztof Kozlowski <krzk+dt@...nel.org>, 
 linux-arm-kernel@...ts.infradead.org, 
 Kursad Oney <kursad.oney@...adcom.com>, devicetree@...r.kernel.org, 
 Conor Dooley <conor+dt@...nel.org>, linux-kernel@...r.kernel.org, 
 Anand Gore <anand.gore@...adcom.com>
Subject: Re: [PATCH] dt-bindings: reset: brcm,bcm63138-pmb: convert to yaml


On Tue, 11 Jun 2024 09:23:23 +0530, Kanak Shilledar wrote:
> Convert the Broadcom BCM63138 Processor Monitor Bus to newer DT
> schema. Created DT schema based on the .txt file which had `compatible`,
> `reg` and `"#reset-cells" as required properties.
> Added one line description which was missing in the original .txt file.
> Added Philipp Zabel as the maintainer (took from MAINTAINERS file).
> 
> Signed-off-by: Kanak Shilledar <kanakshilledar@...il.com>
> ---
>  .../bindings/reset/brcm,bcm63138-pmb.txt      | 19 --------
>  .../bindings/reset/brcm,bcm63138-pmb.yaml     | 43 +++++++++++++++++++
>  2 files changed, 43 insertions(+), 19 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/reset/brcm,bcm63138-pmb.txt
>  create mode 100644 Documentation/devicetree/bindings/reset/brcm,bcm63138-pmb.yaml
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/reset/brcm,bcm63138-pmb.example.dtb: reset-controller@...0c0: '#power-domain-cells' is a required property
	from schema $id: http://devicetree.org/schemas/power/brcm,bcm-pmb.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/reset/brcm,bcm63138-pmb.example.dtb: reset-controller@...0c0: '#reset-cells' does not match any of the regexes: 'pinctrl-[0-9]+'
	from schema $id: http://devicetree.org/schemas/power/brcm,bcm-pmb.yaml#

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240611035329.33648-2-kanakshilledar@gmail.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.