linux-kernel - Re: [PATCH] dt-bindings: reset: brcm,bcm63138-pmb: convert to yaml

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <398ee3a7-513e-4dd6-8ff9-b7585f005d28@kernel.org>
Date: Tue, 11 Jun 2024 08:58:14 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Kanak Shilledar <kanakshilledar@...il.com>
Cc: Philipp Zabel <p.zabel@...gutronix.de>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, William Zhang <william.zhang@...adcom.com>,
 Anand Gore <anand.gore@...adcom.com>, Kursad Oney
 <kursad.oney@...adcom.com>, Florian Fainelli
 <florian.fainelli@...adcom.com>, Rafał Miłecki
 <rafal@...ecki.pl>,
 Broadcom internal kernel review list
 <bcm-kernel-feedback-list@...adcom.com>,
 Kanak Shilledar <kanakshilledar111@...tonmail.com>,
 devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: reset: brcm,bcm63138-pmb: convert to yaml

On 11/06/2024 05:53, Kanak Shilledar wrote:
> Convert the Broadcom BCM63138 Processor Monitor Bus to newer DT
> schema. Created DT schema based on the .txt file which had `compatible`,
> `reg` and `"#reset-cells" as required properties.
> Added one line description which was missing in the original .txt file.
> Added Philipp Zabel as the maintainer (took from MAINTAINERS file).

One of the necessary steps EVERYTIME you make conversion of some random
binding is to grep. git grep. You grep for stale paths and usage of
compatible in DTS. Sometimes you find nothing, sometimes you would find
something.

`git grep bcm63138-pmb` gives you:
1. stale path which you did not fix,
2. duplicated schema...

Best regards,
Krzysztof