linux-kernel - Re: [PATCH 3/3] btrfs: split RAID stripes on deletion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0d744299-99b3-43be-b414-74ba73a4dbab@wdc.com>
Date: Tue, 11 Jun 2024 06:39:23 +0000
From: Johannes Thumshirn <Johannes.Thumshirn@....com>
To: Josef Bacik <josef@...icpanda.com>, Johannes Thumshirn <jth@...nel.org>
CC: Chris Mason <clm@...com>, David Sterba <dsterba@...e.com>,
	"linux-btrfs@...r.kernel.org" <linux-btrfs@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 3/3] btrfs: split RAID stripes on deletion

On 10.06.24 21:45, Josef Bacik wrote:
> On Mon, Jun 10, 2024 at 10:40:27AM +0200, Johannes Thumshirn wrote:
>> From: JohnnesThumshirn <johannes.thumshirn@....com>
>>
>> The current RAID stripe code assumes, that we will always remove a
>> whole stripe entry.
>>
>> But ff we're only removing a part of a RAID stripe we're hitting the
>> ASSERT()ion checking for this condition.
>>
>> Instead of assuming the complete deletion of a RAID stripe, split the
>> stripe if we need to.
>>
>> Signed-off-by: Johnnes Thumshirn <johannes.thumshirn@....com>
> 
> I'd like a selftest for this helper, should be relatively straightforward to do,
> just to test edgecases and such.  Thanks,

Sure. Let me see what I can cook up.