linux-kernel - Re: [PATCH 1/3] btrfs: rst: remove encoding field from stripe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240611143651.GH18508@suse.cz>
Date: Tue, 11 Jun 2024 16:36:51 +0200
From: David Sterba <dsterba@...e.cz>
To: Johannes Thumshirn <jth@...nel.org>
Cc: Chris Mason <clm@...com>, Josef Bacik <josef@...icpanda.com>,
	David Sterba <dsterba@...e.com>, linux-btrfs@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Johannes Thumshirn <johannes.thumshirn@....com>
Subject: Re: [PATCH 1/3] btrfs: rst: remove encoding field from stripe_extent

On Mon, Jun 10, 2024 at 10:40:25AM +0200, Johannes Thumshirn wrote:
> -#define BTRFS_STRIPE_RAID5	5
> -#define BTRFS_STRIPE_RAID6	6
> -#define BTRFS_STRIPE_RAID1C3	7
> -#define BTRFS_STRIPE_RAID1C4	8
> -
>  struct btrfs_stripe_extent {
> -	__u8 encoding;
> -	__u8 reserved[7];
>  	/* An array of raid strides this stripe is composed of. */
> -	struct btrfs_raid_stride strides[];
> +	__DECLARE_FLEX_ARRAY(struct btrfs_raid_stride, strides);

Is there a reason to use the __ underscore macro? I see no difference
between that and DECLARE_FLEX_ARRAY and underscore usually means that
it's special in some way.